Run only unit tests for now #183
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
k8s-ci-robot
added
approved
|
/assign @msau42 |
msau42
reviewed
Oct 21, 2019
release-tools/prow.sh
Outdated
| @@ -242,7 +242,9 @@ configvar CSI_PROW_DEP_VERSION v0.5.1 "golang dep version to be used for vendor | |||
| # thus only makes sense in repos which provide their own CSI | |||
| # driver. Repos can enable sanity testing by setting | |||
| # CSI_PROW_TESTS_SANITY=sanity. | |||
| configvar CSI_PROW_TESTS "unit parallel serial parallel-alpha serial-alpha sanity" "tests to run" | |||
| # NOTE(xyang): Run only unit tests until snapshot beta API PR is merged. | |||
| configvar CSI_PROW_TESTS "unit" "tests to run" | |||
There was a problem hiding this comment.
instead of modifying this, I would modify https://github.com/kubernetes-csi/external-snapshotter/blob/master/.prow.sh instead to override this variable
This PR disable all other tests except the unit tests until the snapshot beta API PR is merged.
xing-yang
force-pushed
the
run_only_unit_tests
branch
from
982629f to
44cfe31
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: xing-yang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have chicken and egg problems between external-snapshotter and hostpath csi driver as we're moving snapshots from alpha to beta and making changes in the way snapshots is deployed. So this PR temporarily disables other tests until the snapshot beta API PR is merged.
What type of PR is this?
/kind failing-test
What this PR does / why we need it:
This PR disable all other tests except the unit tests until
the snapshot beta API PR is merged.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: