Remove PVC finalizer when no longer in use #232
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: xing-yang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
|
Looks good! |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PVC Finalizer is intended to prevent PVC from being deleted when there is a snapshot actively being created from it. After the snapshot is created successfully and in ReadyToUse status, and if there are no other snapshots actively being created from this PVC, the PVC finalizer should be removed.
This is a bug introduced by the latest code refactoring. Without this fix, the current code only removes the PVC finalizer when the snapshot has a deletionTimestamp. The fix here is to move the code that removes the PVC finalizer outside of the function that handles the snapshot with a deletionTimestamp in syncSnapshot(). This way PVC finalizer will always be removed when it is not needed actively as a source.
What type of PR is this?
/kind bug
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #231
Special notes for your reviewer:
Does this PR introduce a user-facing change?: