Skip to content

Add changelog for 2.0.1 release #244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 23, 2020
Merged

Add changelog for 2.0.1 release #244

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG-2.0.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
# Changelog since v2.0.0

## Breaking Changes

- Cherry pick PR #240: Fix go module requirements for semantic versioning. Update package path to v2. Vendoring with dep depends on https://github.com/golang/dep/pull/1963 or the workaround described in v2/README.md. ([#243](https://github.com/kubernetes-csi/external-snapshotter/pull/243), [@alex1989hu](https://github.com/alex1989hu))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jsafrane can you check if attacher also has similar issue?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe. I admit I still don't fully understand the issue even after reading #239

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If someone needs to do a "go get -v github.com/kubernetes-csi/[email protected]", that will probably fail with the similar error because there's no v2 in the package path.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you try to import a go module that's tagged with >= 2.0, the packages need to be in v2 directory. But some workarounds need to be done to still make it work with dep

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ack, filled kubernetes-csi/external-attacher#208

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After cutting the v2.0.1 release, I'm still getting the same errors. Need to figure out what else needs to be fixed.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kindly ask you to see my comments:

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @alex1989hu. I'll give it a try.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified "go get -u github.com/kubernetes-csi/external-snapshotter/[email protected]" works for me now.
Also tested the manual steps to generate code and that works too.


# Changelog since v1.2.0

## New Features
Expand Down