Skip to content

Added go modules for Apis and Client #307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 20, 2020
Merged

Added go modules for Apis and Client #307

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ae21521
Added go modules for Apis and Client
Jun 25, 2020
d8ff17b
Update README
Jul 31, 2020
1ee19f1
Add check for update-crd script file
Aug 7, 2020
4807a7b
move hack to client
Aug 12, 2020
8ae798a
Move Hack to Client directory and update README
Aug 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
0 pkg/apis/volumesnapshot/v1beta1/doc.go → client/apis/volumesnapshot/v1beta1/doc.go
View file
Open in desktop
File renamed without changes.
0 pkg/apis/volumesnapshot/v1beta1/register.go → ...t/apis/volumesnapshot/v1beta1/register.go
View file
Open in desktop
File renamed without changes.
0 pkg/apis/volumesnapshot/v1beta1/types.go → client/apis/volumesnapshot/v1beta1/types.go
View file
Open in desktop
File renamed without changes.
0 ...snapshot/v1beta1/zz_generated.deepcopy.go → ...snapshot/v1beta1/zz_generated.deepcopy.go
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion pkg/client/clientset/versioned/clientset.go → client/clientset/versioned/clientset.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 pkg/client/clientset/versioned/doc.go → client/clientset/versioned/doc.go
View file
Open in desktop
File renamed without changes.
6 changes: 3 additions & 3 deletions ...set/versioned/fake/clientset_generated.go → ...set/versioned/fake/clientset_generated.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 pkg/client/clientset/versioned/fake/doc.go → client/clientset/versioned/fake/doc.go
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion ...ient/clientset/versioned/fake/register.go → client/clientset/versioned/fake/register.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 pkg/client/clientset/versioned/scheme/doc.go → client/clientset/versioned/scheme/doc.go
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion ...nt/clientset/versioned/scheme/register.go → ...nt/clientset/versioned/scheme/register.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 ...ioned/typed/volumesnapshot/v1beta1/doc.go → ...ioned/typed/volumesnapshot/v1beta1/doc.go
View file
Open in desktop
File renamed without changes.
0 .../typed/volumesnapshot/v1beta1/fake/doc.go → .../typed/volumesnapshot/v1beta1/fake/doc.go
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion ...pshot/v1beta1/fake/fake_volumesnapshot.go → ...pshot/v1beta1/fake/fake_volumesnapshot.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion ...1beta1/fake/fake_volumesnapshot_client.go → ...1beta1/fake/fake_volumesnapshot_client.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion .../v1beta1/fake/fake_volumesnapshotclass.go → .../v1beta1/fake/fake_volumesnapshotclass.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion ...1beta1/fake/fake_volumesnapshotcontent.go → ...1beta1/fake/fake_volumesnapshotcontent.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 ...mesnapshot/v1beta1/generated_expansion.go → ...mesnapshot/v1beta1/generated_expansion.go
View file
Open in desktop
File renamed without changes.
4 changes: 2 additions & 2 deletions .../volumesnapshot/v1beta1/volumesnapshot.go → .../volumesnapshot/v1beta1/volumesnapshot.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions ...snapshot/v1beta1/volumesnapshot_client.go → ...snapshot/v1beta1/volumesnapshot_client.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions ...mesnapshot/v1beta1/volumesnapshotclass.go → ...mesnapshot/v1beta1/volumesnapshotclass.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions ...snapshot/v1beta1/volumesnapshotcontent.go → ...snapshot/v1beta1/volumesnapshotcontent.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions ...storage.k8s.io_volumesnapshotclasses.yaml → ...storage.k8s.io_volumesnapshotclasses.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@ apiVersion: apiextensions.k8s.io/v1beta1
kind: CustomResourceDefinition
metadata:
annotations:
controller-gen.kubebuilder.io/version: v0.2.5
api-approved.kubernetes.io: "https://github.com/kubernetes-csi/external-snapshotter/pull/260"
controller-gen.kubebuilder.io/version: v0.3.0
api-approved.kubernetes.io: "https://github.com/kubernetes-csi/external-snapshotter/pull/139"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you change the controller-gen version from v0.2.5 to 0.3.0?
controller-gen.kubebuilder.io/version: v0.3.0

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xing-yang in my enviorment whenever i run the script for update-crd.sh its automatically takes the 0.2.5 version.However i manually update this version to 0.3.0

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can't manually change this version. This has to be automatically generated. It means you have controller-gen 0.2.5 installed on your setup.

Check controller-gen --version

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xing-yang yes, after updating the version in my enviorment it is working fine now when i run the script i got the expected output. The commit running fine

creationTimestamp: null
name: volumesnapshotclasses.snapshot.storage.k8s.io
spec:
Expand Down
4 changes: 2 additions & 2 deletions ...torage.k8s.io_volumesnapshotcontents.yaml → ...torage.k8s.io_volumesnapshotcontents.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@ apiVersion: apiextensions.k8s.io/v1beta1
kind: CustomResourceDefinition
metadata:
annotations:
controller-gen.kubebuilder.io/version: v0.2.5
api-approved.kubernetes.io: "https://github.com/kubernetes-csi/external-snapshotter/pull/260"
controller-gen.kubebuilder.io/version: v0.3.0
api-approved.kubernetes.io: "https://github.com/kubernetes-csi/external-snapshotter/pull/139"
creationTimestamp: null
name: volumesnapshotcontents.snapshot.storage.k8s.io
spec:
Expand Down
8 changes: 3 additions & 5 deletions ...pshot.storage.k8s.io_volumesnapshots.yaml → ...pshot.storage.k8s.io_volumesnapshots.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@ apiVersion: apiextensions.k8s.io/v1beta1
kind: CustomResourceDefinition
metadata:
annotations:
controller-gen.kubebuilder.io/version: v0.2.5
api-approved.kubernetes.io: "https://github.com/kubernetes-csi/external-snapshotter/pull/260"
controller-gen.kubebuilder.io/version: v0.3.0
api-approved.kubernetes.io: "https://github.com/kubernetes-csi/external-snapshotter/pull/139"
creationTimestamp: null
name: volumesnapshots.snapshot.storage.k8s.io
spec:
Expand Down Expand Up @@ -157,9 +157,7 @@ spec:
of a snapshot is unknown.
type: boolean
restoreSize:
anyOf:
- type: integer
- type: string
type: string
description: restoreSize represents the complete size of the snapshot
in bytes. In dynamic snapshot creation case, this field will be filled
in with the "size_bytes" value returned from CSI "CreateSnapshotRequest"
Expand Down
11 changes: 11 additions & 0 deletions client/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
module github.com/kubernetes-csi/external-snapshotter/client/v2

go 1.12
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this need to be updated?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @msau42 could you please clarify if i am not wrong ,are you mentionig here to update go version to 1.13 ?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other sidecars are using go 1.13 so we should update to 1.13 as well, but it's fine if you update go version in a separate PR . This PR already has lots of changes.


require (
golang.org/x/oauth2 v0.0.0-20200107190931-bf48bf16ab8d // indirect
golang.org/x/time v0.0.0-20200416051211-89c76fbcd5d1 // indirect
k8s.io/api v0.19.0-rc.2
k8s.io/apimachinery v0.19.0-rc.2
k8s.io/client-go v0.19.0-rc.2
)
Loading