Skip to content

Update vendor files to point to K8S 1.12.0 #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 5, 2018
Merged

Update vendor files to point to K8S 1.12.0 #37

merged 1 commit into from
Oct 5, 2018

Conversation

xing-yang
Copy link
Collaborator

@xing-yang xing-yang commented Oct 2, 2018 •
edited
Loading

This PR updates vendor files to point to K8S 1.12.0.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 2, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xing-yang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 2, 2018
@xing-yang
Copy link
Collaborator Author

@verult @jingxu97 Please take a look. Thanks.

@jingxu97
Copy link
Collaborator

jingxu97 commented Oct 3, 2018

lgtm

@verult
Copy link
Contributor

verult commented Oct 4, 2018

/lgtm

@k8s-ci-robot
Copy link
Contributor

@verult: changing LGTM is restricted to assignees, and only kubernetes-csi/external-snapshotter repo collaborators may be assigned issues.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@xing-yang
Update vendor files to point to K8S 1.12.0
ec08855 
This PR updates vendor files to point to K8S 1.12.0.
@xing-yang xing-yang changed the title Update vendor files to point to K8S 1.12.0-rc.2 Update vendor files to point to K8S 1.12.0 Oct 5, 2018
@xing-yang
Copy link
Collaborator Author

kubernetes-1.12.0 tag is cut for k8s/api, k8s/apimachinery, etc. now.

@lpabon
Copy link
Member

lpabon commented Oct 5, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 5, 2018
@k8s-ci-robot k8s-ci-robot merged commit d50a9a9 into kubernetes-csi:master Oct 5, 2018
@xing-yang xing-yang deleted the update_version branch April 8, 2019 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rootfs rootfs Awaiting requested review from rootfs

@saad-ali saad-ali Awaiting requested review from saad-ali

Assignees

@lpabon lpabon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@xing-yang @k8s-ci-robot @jingxu97 @verult @lpabon