Switch to using google.golang.org/protobuf rather than github.com/golang/protobuf #829

ghakazian · 2023-04-16T21:15:30Z

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
This PR removes an explicit dependency on a deprecated package

Which issue(s) this PR fixes:
Fixes #804

Special notes for your reviewer:
This is my first K8s PR so any constructive criticism would be welcome. Thanks!
Does this PR introduce a user-facing change?:

NONE

…ang/protobuf

k8s-ci-robot · 2023-04-16T21:15:38Z

Welcome @ghakazian!

It looks like this is your first PR to kubernetes-csi/external-snapshotter 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-csi/external-snapshotter has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2023-04-16T21:15:39Z

Hi @ghakazian. Thanks for your PR.

I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

xing-yang · 2023-04-17T09:36:10Z

go.mod

@@ -38,6 +38,7 @@ require (
 	github.com/go-openapi/swag v0.22.3 // indirect
 	github.com/gogo/protobuf v1.3.2 // indirect
 	github.com/golang/groupcache v0.0.0-20210331224755-41bb18bfe9da // indirect
+	github.com/golang/protobuf v1.5.3 // indirect


This is still used here.

Understood, it is still pulled in as an indirect dependency by a number of other components.

@xing-yang Any chance this can be approved? I removed the explicit dependency on github.com/golang/protobuf; the remaining indirect reference comes from other components that still use github.com/golang/protobuf.
If I am missing other steps that I should do as part of this PR to remove the indirect dependency, please let me know. Thanks.

Can you check who is making this indirect dep? You can try this "go mod why -m ".

It looks like it is being pulled in by github.com/container-storage-interface/spec/lib/go/csi

Thanks for checking!

xing-yang · 2023-04-17T09:36:37Z

/ok-to-test

xing-yang · 2023-04-27T18:02:32Z

pkg/snapshotter/snapshotter.go

-		return "", "", time.Time{}, 0, false, err
-	}
+
+	creationTime := rsp.Snapshot.CreationTime.AsTime()


Any error check for this? Could "creationTime" be nil?

The AsTime() method returns a time.Time struct (not an interface or pointer) which cannot be nil, and since the method does not return an error, there is nothing to error check.

xing-yang · 2023-04-27T18:02:42Z

pkg/snapshotter/snapshotter.go

-	if err != nil {
-		return false, time.Time{}, 0, err
-	}
+	creationTime := rsp.Entries[0].Snapshot.CreationTime.AsTime()


Same as above.

Response same as above, AsTime() doesn't return a nillable type or an error to check.

xing-yang · 2023-04-27T18:02:59Z

pkg/snapshotter/snapshotter_test.go

-		t.Fatalf("Failed to convert timestamp to time: %v", err)
-	}
+	createTimestamp := timestamppb.Now()
+	createTime := createTimestamp.AsTime()


Same as above.

Response same as above, AsTime() doesn't return a nillable type or an error to check.

xing-yang · 2023-04-27T18:03:09Z

pkg/snapshotter/snapshotter_test.go

-		t.Fatalf("Failed to convert timestamp to time: %v", err)
-	}
+	createTimestamp := timestamppb.Now()
+	createTime := createTimestamp.AsTime()


Same as above.

Response same as above, AsTime() doesn't return a nillable type or an error to check.

xing-yang · 2023-04-27T18:03:51Z

go.mod

@@ -38,6 +38,7 @@ require (
 	github.com/go-openapi/swag v0.22.3 // indirect
 	github.com/gogo/protobuf v1.3.2 // indirect
 	github.com/golang/groupcache v0.0.0-20210331224755-41bb18bfe9da // indirect
+	github.com/golang/protobuf v1.5.3 // indirect


Can you check who is making this indirect dep? You can try this "go mod why -m ".

ghakazian · 2023-04-27T23:44:12Z

@xing-yang Looking at output from go mod why -m , it looks like the dependency is being pulled in by github.com/container-storage-interface/spec.
Confirmed looking at the source code for that project that it is still requiring an explicit dependency on github.com/golang/protobuf.

xing-yang · 2023-04-28T17:22:48Z

/lgtm
/approve

k8s-ci-robot · 2023-04-28T17:22:53Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ghakazian, xing-yang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [xing-yang]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Switch to using google.golang.org/protobuf rather than github.com/gol…

8a11d50

…ang/protobuf

k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 16, 2023

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 16, 2023

k8s-ci-robot requested review from jingxu97 and mauriciopoppe April 16, 2023 21:15

k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 16, 2023

xing-yang reviewed Apr 17, 2023

View reviewed changes

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 17, 2023

xing-yang reviewed Apr 27, 2023

View reviewed changes

xing-yang mentioned this pull request Apr 28, 2023

Dependency tree were found to be deprecated github.com/golang/protobuf container-storage-interface/spec#516

Open

k8s-ci-robot assigned xing-yang Apr 28, 2023

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 28, 2023

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 28, 2023

k8s-ci-robot merged commit 9b0ea01 into kubernetes-csi:master Apr 28, 2023

ghakazian deleted the fix_deprecated_protobuf branch April 28, 2023 23:52

niranjandarshann mentioned this pull request Jul 22, 2024

module github.com/golang/protobuf is deprecated: Use the "google.golang.org/protobuf" module instead kubernetes-csi/csi-lib-utils#115

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Switch to using google.golang.org/protobuf rather than github.com/golang/protobuf #829

Switch to using google.golang.org/protobuf rather than github.com/golang/protobuf #829

ghakazian commented Apr 16, 2023

k8s-ci-robot commented Apr 16, 2023

k8s-ci-robot commented Apr 16, 2023

xing-yang Apr 17, 2023

ghakazian Apr 17, 2023

ghakazian Apr 27, 2023

xing-yang Apr 27, 2023

ghakazian Apr 27, 2023

xing-yang Apr 28, 2023

xing-yang commented Apr 17, 2023

xing-yang Apr 27, 2023

ghakazian Apr 27, 2023

xing-yang Apr 27, 2023

ghakazian Apr 27, 2023

xing-yang Apr 27, 2023

ghakazian Apr 27, 2023

xing-yang Apr 27, 2023

ghakazian Apr 27, 2023

xing-yang Apr 27, 2023

ghakazian commented Apr 27, 2023 •

edited

Loading

xing-yang commented Apr 28, 2023

k8s-ci-robot commented Apr 28, 2023

Switch to using google.golang.org/protobuf rather than github.com/golang/protobuf #829

Switch to using google.golang.org/protobuf rather than github.com/golang/protobuf #829

Conversation

ghakazian commented Apr 16, 2023

k8s-ci-robot commented Apr 16, 2023

k8s-ci-robot commented Apr 16, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

xing-yang commented Apr 17, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ghakazian commented Apr 27, 2023 • edited Loading

xing-yang commented Apr 28, 2023

k8s-ci-robot commented Apr 28, 2023

ghakazian commented Apr 27, 2023 •

edited

Loading