Add mutator functions to allow modify the Kubernetes resources used b… #176
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note
k8s-ci-robot
added
cncf-cla: yes
|
/assign @msau42 |
|
/assign @pwschuurman |
pwschuurman
reviewed
Dec 27, 2024
pwschuurman
reviewed
Dec 28, 2024
pwschuurman
approved these changes
Dec 28, 2024
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/approve |
k8s-ci-robot
removed
the
lgtm
msau42
reviewed
Dec 31, 2024
populator-machinery/controller.go
Outdated
| @@ -189,6 +194,19 @@ type PopulatorParams struct { | |||
| Recorder record.EventRecorder | |||
| } | |||
|
|
|||
| type MutatorConfig struct { | |||
| // PvcPrimeMutator is the mutator function for pvcPrime | |||
There was a problem hiding this comment.
Add a comment about when this will be called.
|
Thanks, can you squash the commits? /approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dannawang0221, msau42, pwschuurman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
…y volume population
dannawang0221
force-pushed
the
add-object-mutator
branch
from
ea8f264 to
c13ed5b
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…y volume population
What type of PR is this?
/kind feature
What this PR does / why we need it:
In some cases we might want to customize the default Kubernetes objects in volume populator, so add plugin functions to allow modification for the objects.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: