Move to apiserver_request_sli_ metric
#874
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The older `apiserver_request_sli_.*` metrics have been name changed starting in Kubernetes v1.26. kubernetes/kubernetes#112679
|
I'm not merging as I'm not sure that we only target Kube v1.26 and above on main now. If someone knows this to be true, feel free to merge. |
|
I guess we'll see and figure out. |
|
@metalmatze should we update the compatibility matrix? |
|
Yes, please send a PR. |
dohnto-s1
added a commit
to Sentinel-One/kubernetes-mixin
that referenced
this pull request
Oct 27, 2023
|
yes the current OpenShift release (4.13) uses 1.26. So that works for us. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The older
apiserver_request_sli_.*metrics have been name changed starting in Kubernetes v1.26.kubernetes/kubernetes#112679