Skip to content
This repository was archived by the owner on Apr 23, 2019. It is now read-only.

Added missing required files #46

Merged
merged 1 commit into from
Aug 7, 2018
Merged

Added missing required files #46

merged 1 commit into from
Aug 7, 2018

Conversation

jdumars
Copy link
Contributor

@jdumars jdumars commented Aug 7, 2018

Added OWNERS AND SECURITY_CONTACTS files per kubernetes/community#2476

@jdumars jdumars added committee/steering Denotes an issue or PR intended to be handled by the steering committee. sig/architecture Categorizes an issue or PR as relevant to sig-architecture. labels Aug 7, 2018
@jdumars jdumars requested a review from bgrant0607 August 7, 2018 04:15
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jdumars
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:

If they are not already assigned, you can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 7, 2018
@jdumars jdumars mentioned this pull request Aug 7, 2018
Closed
@cblecker
Copy link

cblecker commented Aug 7, 2018

/lgtm

@jdumars you can manually merge when ready, as 1) there isn't tide configured on this repo for auto merging and 2) there isn't an OWNERS file yet, so you won't have anyone to approve it.

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 7, 2018
@spiffxp
Copy link
Contributor

spiffxp commented Aug 7, 2018

spoke with @jdumars offline, merging manually and setting up tide so that /approve == merge next time

@spiffxp spiffxp merged commit 37b4dfc into kubernetes-retired:master Aug 7, 2018
@spiffxp spiffxp mentioned this pull request Aug 7, 2018
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bgrant0607 bgrant0607 Awaiting requested review from bgrant0607

Assignees

@spiffxp spiffxp

@cblecker cblecker

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. committee/steering Denotes an issue or PR intended to be handled by the steering committee. lgtm Indicates that a PR is ready to be merged. sig/architecture Categorizes an issue or PR as relevant to sig-architecture. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jdumars @k8s-ci-robot @cblecker @spiffxp