Skip to content
This repository was archived by the owner on Apr 17, 2025. It is now read-only.

Update to Go 1.21 #406

Merged
merged 1 commit into from
Mar 2, 2025

Conversation

pjonsson
Copy link
Contributor

@pjonsson pjonsson commented Mar 1, 2025

Bump the Go versions in various
files, and run go mod tidy to
clean up things.

Bump the Go versions in various
files, and run go mod tidy to
clean up things.
@k8s-ci-robot k8s-ci-robot requested review from rjbez17 and tashimi March 1, 2025 20:37
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 1, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @pjonsson. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 1, 2025
@pjonsson
Copy link
Contributor Author

pjonsson commented Mar 1, 2025

This passes go test ./api/... ./cmd/... ./internal/... -coverprofile cover.out in a Go 1.21 image for me locally, and the Dockerfile builds. I hijacked #374 where I already had ok-to-test and this passed the pull-hnc-test job there. Not sure how the pull-hnc-test job could pass since that uses a Go 1.20 image, but it did.

Filed kubernetes/test-infra#34440 to fix presubmit.

@rjbez17
Copy link
Contributor

rjbez17 commented Mar 2, 2025

/ok-to-test
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 2, 2025
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 2, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pjonsson, rjbez17

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 2, 2025
@k8s-ci-robot k8s-ci-robot merged commit 425f857 into kubernetes-retired:master Mar 2, 2025
3 checks passed
@pjonsson pjonsson deleted the update-golang-121 branch March 2, 2025 10:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants