This repository was archived by the owner on May 22, 2020. It is now read-only.
Add firewall configuration section to README #460
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a section on how to configure GCP firewall rules to enable cluster-api to orchestrate GCP VMs.
k8s-ci-robot
added
the
cncf-cla: yes
|
This change is |
k8s-ci-robot
added
the
size/S
|
Hi @timothysc, you mentioned you were reviewing pending PRs. Can you take a look at this one? It addresses an issue I've noticed a few people hit on the channel. I created issue #459 to track. |
|
Hi @delapsley. I'm sorry I didn't see this PR before, I must need to reconfigure notifications for this repository. We just merged #486 from @jessicaochen that adds a similar section to the readme so I'm going to close this PR as a duplicate. In the near future we will have OWNERS files in place and automation to automatically assign PRs, so things like this shouldn't fall through the cracks (see #481). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a section on how to configure GCP firewall rules to enable cluster-api to orchestrate GCP VMs.