Skip to content

Switching to a longer test timeout. #690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 21, 2025

Conversation

cheftako
Copy link
Contributor

Github actions seem significantly under resourced. As a result we get a high level of flakes where CPU starved goroutines are not completing inside of 30 seconds.

Github actions seem significantly under resourced.
As a result we get a high level of flakes where CPU
starved goroutines are not completing inside of 30 seconds.
@cheftako cheftako requested a review from tallclair January 17, 2025 20:27
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheftako

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested a review from ipochi January 17, 2025 20:27
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 17, 2025
@cheftako
Copy link
Contributor Author

/test pull-apiserver-network-proxy-test-master

1 similar comment
@cheftako
Copy link
Contributor Author

/test pull-apiserver-network-proxy-test-master

@jkh52
Copy link
Contributor

jkh52 commented Jan 22, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 22, 2025
)

var ForeverTestTimeout = time.Minute
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: const

@jkh52
Copy link
Contributor

jkh52 commented Feb 21, 2025

/retest

@k8s-ci-robot k8s-ci-robot merged commit 736cc70 into kubernetes-sigs:master Feb 21, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants