Skip to content

feat: switch to bookworm debian base image #1090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 8, 2023

Conversation

cvvz
Copy link
Member

@cvvz cvvz commented Nov 6, 2023

What type of PR is this?
/kind feature

What this PR does / why we need it:
feat: switch to bookworm debian base image

bookworm debian base image has fewer CVEs compared to bulleye debian base image

# bookworm 
==============================================
Total: 97 (UNKNOWN: 0, LOW: 72, MEDIUM: 14, HIGH: 10, CRITICAL: 1)

# bulleye
==============================================
Total: 210 (UNKNOWN: 0, LOW: 104, MEDIUM: 47, HIGH: 50, CRITICAL: 9)

Which issue(s) this PR fixes:

Fixes #

Requirements:

Special notes for your reviewer:

Release note:

feat: switch to bookworm debian base image

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 6, 2023
@andyzhangx
Copy link
Member

/retest

@cvvz
Copy link
Member Author

cvvz commented Nov 6, 2023

/retest

@cvvz
Copy link
Member Author

cvvz commented Nov 6, 2023

something bad happened to aznfs, I'm investigating.

@cvvz
Copy link
Member Author

cvvz commented Nov 6, 2023

something bad happened to aznfs, I'm investigating.

fixed

@cvvz
Copy link
Member Author

cvvz commented Nov 7, 2023

/retest

2 similar comments
@cvvz
Copy link
Member Author

cvvz commented Nov 7, 2023

/retest

@andyzhangx
Copy link
Member

/retest

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 7, 2023
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 7, 2023
@cvvz
Copy link
Member Author

cvvz commented Nov 8, 2023

/retest

Copy link
Member

@andyzhangx andyzhangx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 8, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, cvvz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 8, 2023
@andyzhangx andyzhangx merged commit 819ecfe into kubernetes-sigs:master Nov 8, 2023
@andyzhangx
Copy link
Member

/cherrypick release-1.23

@k8s-infra-cherrypick-robot

@andyzhangx: #1090 failed to apply on top of branch "release-1.23":

Applying: feat: switch to bookworm debian base image
Using index info to reconstruct a base tree...
M	pkg/blobplugin/Dockerfile
Falling back to patching base and 3-way merge...
Auto-merging pkg/blobplugin/Dockerfile
CONFLICT (content): Merge conflict in pkg/blobplugin/Dockerfile
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 feat: switch to bookworm debian base image
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick release-1.23

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@andyzhangx
Copy link
Member

@cvvz pls also cherrypick this PR to release-1.23, 1.22, 1.21, thanks.

@k8s-ci-robot
Copy link
Contributor

@cvvz: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-blob-csi-driver-external-e2e-nfs a394206 link unknown /test pull-blob-csi-driver-external-e2e-nfs
pull-blob-csi-driver-e2e-proxy a394206 link unknown /test pull-blob-csi-driver-e2e-proxy
pull-blob-csi-driver-e2e a394206 link unknown /test pull-blob-csi-driver-e2e

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

cvvz added a commit to cvvz/blob-csi-driver that referenced this pull request Nov 9, 2023
* feat: switch to bookworm debian base image

* fix
cvvz added a commit to cvvz/blob-csi-driver that referenced this pull request Nov 9, 2023
* feat: switch to bookworm debian base image

* fix
cvvz added a commit to cvvz/blob-csi-driver that referenced this pull request Nov 9, 2023
* feat: switch to bookworm debian base image

* fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants