-
Notifications
You must be signed in to change notification settings - Fork 87
feat: match source account as first priority in volume restore #1739
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: match source account as first priority in volume restore #1739
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andyzhangx The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no suggestions.
Comments skipped due to low confidence (1)
pkg/blob/controllerserver.go:315
- [nitpick] The error message 'VolumeContentSource Snapshot is not yet implemented' is unclear. Consider providing more details or guidance.
return nil, status.Errorf(codes.InvalidArgument, "VolumeContentSource Snapshot is not yet implemented")
/cherrypick release-1.25 |
/cherrypick release-1.24 |
/cherrypick release-1.23 |
@andyzhangx: #1739 failed to apply on top of branch "release-1.23":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@andyzhangx: new pull request created: #1740 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@andyzhangx: new pull request created: #1741 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What type of PR is this?
/kind feature
What this PR does / why we need it:
feat: match source account as first priority in volume restore
Which issue(s) this PR fixes:
Fixes #
Requirements:
Special notes for your reviewer:
Release note: