-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support workload identity #1798
feat: support workload identity #1798
Conversation
Really glad to see some progress on this feature! I know it's WIP so perhaps you're already planning to address, but I wanted to mention that the token audience varies by cloud so that will need to be dynamic or configurable. eg:
|
I've went through the doc
|
@acortelyou Thanks for your kindly reminder. We will keep the token audience unchanged in this PR. And we are discussing whether it should be changed by cloud. If so, we will file another pr to fix it (not only in blob driver but also azurefile driver). |
/retest |
|
||
// parseServiceAccountToken parses the bound service account token from the token passed from NodePublishVolume Request. | ||
// ref: https://kubernetes-csi.github.io/docs/token-requests.html | ||
func parseServiceAccountToken(tokenStr string) (string, error) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you add the ut?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pls add the ut in another PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andyzhangx, cvvz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
/cherrypick release-1.26 |
@andyzhangx: new pull request created: #1888 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/cherrypick release-1.25 |
@andyzhangx: new pull request created: #1889 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What type of PR is this?
/kind feature
What this PR does / why we need it:
The previous implementation of supporting workload identity is to use workload identity to retrieve account key for mounting. Since blobfuse2 has supported workload identity authentication, we can use workload identity to directly mount without retrieving account key.
Which issue(s) this PR fixes:
Fixes #
Requirements:
Special notes for your reviewer:
Release note: