-
Notifications
You must be signed in to change notification settings - Fork 87
test: add UT for blobfuse-proxy/main.go #1801
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi @Zhupku. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
35619a0
to
73613f9
Compare
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andyzhangx, Zhupku The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This pull request to
pkg/blobfuse-proxy
introduces a mechanism to mock the gRPC server runner for testing purposes. The most important changes include adding a new variable to hold the gRPC server runner function, updating the main function to use this new variable, and creating a test to mock the gRPC server runner.Changes to enable mocking the gRPC server runner:
pkg/blobfuse-proxy/main.go
: Added a new variablegrpcServerRunner
to hold the gRPC server runner function and updated the main function to use this variable instead of callingserver.RunGRPCServer
directly. [1] [2]Tests for the new mocking mechanism:
pkg/blobfuse-proxy/main_test.go
: Added a new test file to mock the gRPC server runner and test the main function.<!-- Thanks for sending a pull request! Here are some tips for you:https://git.k8s.io/community/contributors/devel/release.md#issue-kind-label
-->
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Requirements:
Special notes for your reviewer:
Release note: