Skip to content

feat: provide latency data in logs #630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 20, 2022
Merged

feat: provide latency data in logs #630

merged 2 commits into from
Mar 20, 2022

Conversation

andyzhangx
Copy link
Member

@andyzhangx andyzhangx commented Mar 19, 2022 •
edited
Loading

What type of PR is this?
/kind feature

What this PR does / why we need it:
feat: provide latency data in logs

Which issue(s) this PR fixes:

Fixes #

Requirements:

Special notes for your reviewer:

"Observed Request Latency" latency_seconds=0.06656757 request="blob_csi_driver_controller_create_volume" resource_group="kubetest-ld6cfkkv" subscription_id="0e46bd28-a80f-4d3a-8200-d9eb8d80cb2e" source="blob.csi.azure.com" kubetest-ld6cfkkv#fusebe9cc1b24b654247b9d#pvc-e0e111a5-5b9e-4615-b73a-d66e17122fa4="" result_code="succeeded"
"Observed Request Latency" latency_seconds=6.6864543990000005 request="blob_csi_driver_controller_delete_volume" resource_group="kubetest-ld6cfkkv" subscription_id="0e46bd28-a80f-4d3a-8200-d9eb8d80cb2e" source="blob.csi.azure.com" kubetest-ld6cfkkv#fusebe9cc1b24b654247b9d#pvc-e0e111a5-5b9e-4615-b73a-d66e17122fa4="" result_code="succeeded"

Release note:

feat: provide latency data in logs

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Mar 19, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 19, 2022
@andyzhangx andyzhangx changed the title [WIP]feat: provide latency data in logs feat: provide latency data in logs Mar 20, 2022
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 20, 2022
@andyzhangx andyzhangx merged commit 8a19e3c into kubernetes-sigs:master Mar 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feiskyer feiskyer Awaiting requested review from feiskyer

@ZeroMagic ZeroMagic Awaiting requested review from ZeroMagic

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andyzhangx @k8s-ci-robot