Skip to content

WIP Improved Unit-Test Coverage for Issue #703 (please see #736) #723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 31 commits into from
Closed

WIP Improved Unit-Test Coverage for Issue #703 (please see #736) #723

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
f7a4076
added unit tests for getSubnetResourceID() and useDataPlaneAPI()
Jul 5, 2022
cfa6397
fixed sig error for TestGetSubnetResourceID()
aarongalang Jul 5, 2022
ade9f5a
added unit tests for GetStorageAccessKey() and GetStorageAccountFromS…
aarongalang Jul 6, 2022
cd10164
added 2 testcases for getContainerReference()
aarongalang Jul 8, 2022
45b7f09
Added unit-test for ConvertTagsToMap in util/util_test.go
aarongalang Jul 12, 2022
d022df0
added unit-test for AddNodeServiceCapabilties in csi-common/driver_te…
aarongalang Jul 12, 2022
54ec7bf
completed unit test TestControllerExpandVolume
aarongalang Jul 12, 2022
ed854d8
added unit-test for ControllerGetVolume
aarongalang Jul 13, 2022
c1e1379
Create a mock blob client for controllerserver_test.go
aarongalang Jul 13, 2022
984f16a
rewrote TestValidateVolumeCapabilities() and added more testcases usi…
aarongalang Jul 14, 2022
80a8c8b
Fixed Client Error testcases for TestCreateBlobContainer and TestDele…
aarongalang Jul 15, 2022
aa0748b
Added testcases to TestCreateVolume()
aarongalang Jul 15, 2022
4e58c74
added testcases for CreateVolume and DeleteVolume
aarongalang Jul 19, 2022
b753585
added empty testcase to TestGetMountOptions()
aarongalang Jul 20, 2022
1b17213
added testcase to TestGetContainerReference
aarongalang Jul 20, 2022
0ba1f23
removed unnecessary testcase from testdeletevolume
aarongalang Jul 20, 2022
f4ed930
added testcases for Mount in fakemounter
aarongalang Jul 21, 2022
c46b0ac
added testcases for nodstagevolume and fixed nullpointer error in tes…
aarongalang Jul 25, 2022
a7f487c
added testcase to getAuthEnv, and fixed some asserts (expected and ac…
aarongalang Jul 25, 2022
2b22558
removed faulty testcase
aarongalang Aug 3, 2022
927afaa
Merge branch 'master' into unit-tests
aarongalang Aug 12, 2022
a696421
removed duplicate testcase from TestCreateVolume
aarongalang Aug 12, 2022
cdd40cd
Merge branch 'unit-tests' of https://github.com/aarongalang/blob-csi-…
aarongalang Aug 12, 2022
7e57ff2
updated mockblobclient to return retry.errors instead of regular erro…
aarongalang Aug 12, 2022
1c1bd9d
fixing lint errors
aarongalang Aug 15, 2022
21105dd
Merge branch 'master' into unit-tests
aarongalang Aug 15, 2022
2f5e237
fixing build and lint checks
aarongalang Aug 18, 2022
85b073b
unexporting newMockBlobClient
aarongalang Aug 19, 2022
4cf5c77
adding "ro" to the ignore_words_list (was interpreting read-only as a…
aarongalang Aug 19, 2022
3698bf5
Revert "added unit tests for getSubnetResourceID() and useDataPlaneAP…
aarongalang Aug 19, 2022
7cf6052
reintroducing reverted commit
aarongalang Aug 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/codespell.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,4 +13,4 @@ jobs:
with:
check_filenames: true
skip: ./.git,./.github/workflows/codespell.yml,.git,*.png,*.jpg,*.svg,*.sum,./vendor,go.sum,./release-tools/prow.sh,./pkg/lib/iscsi/
ignore_words_list: "AKS,aks"
ignore_words_list: "AKS,aks,ro"
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ module sigs.k8s.io/blob-csi-driver
go 1.18

require (
github.com/Azure/azure-sdk-for-go v65.0.0+incompatible
github.com/Azure/azure-sdk-for-go v66.0.0+incompatible
github.com/Azure/azure-sdk-for-go/sdk/azidentity v1.0.0
github.com/Azure/go-autorest/autorest v0.11.28
github.com/Azure/go-autorest/autorest/adal v0.9.21
Expand Down
2 changes: 2 additions & 0 deletions go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,8 @@ dmitri.shuralyov.com/gpu/mtl v0.0.0-20201218220906-28db891af037/go.mod h1:H6x//7
github.com/Azure/azure-sdk-for-go v55.0.0+incompatible/go.mod h1:9XXNKU+eRnpl9moKnB4QOLf1HestfXbmab5FXxiDBjc=
github.com/Azure/azure-sdk-for-go v65.0.0+incompatible h1:HzKLt3kIwMm4KeJYTdx9EbjRYTySD/t8i1Ee/W5EGXw=
github.com/Azure/azure-sdk-for-go v65.0.0+incompatible/go.mod h1:9XXNKU+eRnpl9moKnB4QOLf1HestfXbmab5FXxiDBjc=
github.com/Azure/azure-sdk-for-go v66.0.0+incompatible h1:bmmC38SlE8/E81nNADlgmVGurPWMHDX2YNXVQMrBpEE=
github.com/Azure/azure-sdk-for-go v66.0.0+incompatible/go.mod h1:9XXNKU+eRnpl9moKnB4QOLf1HestfXbmab5FXxiDBjc=
github.com/Azure/azure-sdk-for-go/sdk/azcore v1.1.1 h1:tz19qLF65vuu2ibfTqGVJxG/zZAI27NEIIbvAOQwYbw=
github.com/Azure/azure-sdk-for-go/sdk/azcore v1.1.1/go.mod h1:uGG2W01BaETf0Ozp+QxxKJdMBNRWPdstHG0Fmdwn1/U=
github.com/Azure/azure-sdk-for-go/sdk/azidentity v1.0.0 h1:Yoicul8bnVdQrhDMTHxdEckRGX01XvwXDHUT9zYZ3k0=
Expand Down
Loading