Skip to content

feat: support cross subscription with management API #729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Aug 11, 2022
Merged

feat: support cross subscription with management API #729

merged 7 commits into from
Aug 11, 2022

Conversation

cvvz
Copy link
Member

@cvvz cvvz commented Aug 6, 2022

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Requirements:

Special notes for your reviewer:

Release note:

none

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 6, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @cvvz. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 6, 2022
@cvvz
Copy link
Member Author

cvvz commented Aug 6, 2022

/ok-to-test

@k8s-ci-robot
Copy link
Contributor

@cvvz: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@andyzhangx
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 6, 2022
@cvvz
Copy link
Member Author

cvvz commented Aug 6, 2022

/test pull-blob-csi-driver-e2e

@cvvz
Copy link
Member Author

cvvz commented Aug 6, 2022

/test pull-blob-csi-driver-integration

@cvvz cvvz changed the title [WIP]change management api to rest api change management api to rest api Aug 10, 2022
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 10, 2022
@cvvz
Copy link
Member Author

cvvz commented Aug 10, 2022

/retest

1 similar comment
@cvvz
Copy link
Member Author

cvvz commented Aug 10, 2022

/retest

andyzhangx
andyzhangx reviewed Aug 10, 2022
View reviewed changes
@andyzhangx
Copy link
Member

btw, also add a volumeID format doc here: https://github.com/kubernetes-sigs/blob-csi-driver/blob/master/docs/driver-parameters.md

@cvvz cvvz force-pushed the blobclient branch 2 times, most recently from 297ac64 to a73ee55 Compare August 11, 2022 02:19
andyzhangx
andyzhangx reviewed Aug 11, 2022
View reviewed changes
Copy link
Member

@andyzhangx andyzhangx left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to add some comments of the volumeid format, other parts LGTM

@andyzhangx
Copy link
Member

also change the PR title to feat: support cross subscription with management API

@andyzhangx
Copy link
Member

/kind feature

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Aug 11, 2022
@cvvz cvvz changed the title change management api to rest api feat: support cross subscription with management API Aug 11, 2022
@cvvz
Copy link
Member Author

cvvz commented Aug 11, 2022

/retest

1 similar comment
@cvvz
Copy link
Member Author

cvvz commented Aug 11, 2022

/retest

andyzhangx
andyzhangx reviewed Aug 11, 2022
View reviewed changes
pkg/blob/controllerserver.go
@@ -442,7 +442,8 @@ func (d *Driver) ValidateVolumeCapabilities(ctx context.Context, req *csi.Valida
if resourceGroupName == "" {
resourceGroupName = d.cloud.ResourceGroup
}
blobContainer, err := d.cloud.BlobClient.GetContainer(ctx, resourceGroupName, accountName, containerName)
blobContainer, retryErr := d.cloud.BlobClient.GetContainer(ctx, subsID, resourceGroupName, accountName, containerName)
err = retryErr.Error()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

retryErr could be nil, there retryErr.Error() would panic

Copy link
Member Author

@cvvz cvvz Aug 11, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this scenario is handled in the beginning of Error() , that is when retryErr is nil, retryErr.Error() will be nil too.

andyzhangx
andyzhangx approved these changes Aug 11, 2022
View reviewed changes
Copy link
Member

@andyzhangx andyzhangx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 11, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, cvvz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 11, 2022
@k8s-ci-robot k8s-ci-robot merged commit 6f1968e into kubernetes-sigs:master Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyzhangx andyzhangx andyzhangx approved these changes

@ZeroMagic ZeroMagic Awaiting requested review from ZeroMagic

Assignees

@andyzhangx andyzhangx

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cvvz @k8s-ci-robot @andyzhangx