Skip to content

Improved Unit-Test Coverage for Issue #703 #736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Aug 22, 2022
Merged

Improved Unit-Test Coverage for Issue #703 #736

merged 8 commits into from
Aug 22, 2022

Conversation

aarongalang
Copy link
Contributor

@aarongalang aarongalang commented Aug 19, 2022 •
edited
Loading

What type of PR is this?
/kind test

What this PR does / why we need it:
Adds unit-tests to pkg folder for improved coverage

Which issue(s) this PR fixes:
#703

Fixes #

Requirements:

  • adds unit tests
  • tested upgrade from previous version

Special notes for your reviewer:
This PR had to be created because my previous pr had a commit that used my local computer as the author, rather than my git user id. As a result, only that one commit did not have my cla, causing the pr to be mergeable
please see pr #723 for actual commit messages
Release note:

none

@k8s-ci-robot k8s-ci-robot added kind/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 19, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @aarongalang. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Aug 19, 2022
@aarongalang aarongalang mentioned this pull request Aug 19, 2022
Closed
2 tasks
@aarongalang aarongalang changed the title Improved Unit-Test Coverage for Issue #703 WIP Improved Unit-Test Coverage for Issue #703 Aug 19, 2022
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 19, 2022
@aarongalang
Copy link
Contributor Author

accidentally changed the non-test files, undoing them now

@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 19, 2022
@mukhoakash
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 19, 2022
mukhoakash
mukhoakash reviewed Aug 19, 2022
View reviewed changes
pkg/blob/blob.go Outdated
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revert the changes in this file

Copy link
Contributor

@mukhoakash mukhoakash Aug 19, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these created by lint fixes?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah i'm not sure why those ended up there... will revert momentarily

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

double checked my code, those dashes aren't there, might have been created by lint fixes as you said

mukhoakash
mukhoakash reviewed Aug 19, 2022
View reviewed changes
pkg/blob/controllerserver.go Outdated
@@ -1,12 +1,9 @@
/*
Copyright 2017 The Kubernetes Authors.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert, unless created by lint fixes.

mukhoakash
mukhoakash reviewed Aug 19, 2022
View reviewed changes
pkg/blob/nodeserver.go Outdated
@@ -1,12 +1,9 @@
/*
Copyright 2017 The Kubernetes Authors.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same. Revert unless created by lint fix.

mukhoakash
mukhoakash reviewed Aug 19, 2022
View reviewed changes
test/utils/credentials/credentials.go Outdated
@@ -1,12 +1,9 @@
/*
Copyright 2019 The Kubernetes Authors.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same. Revert unless created by lint fix.

@aarongalang
Copy link
Contributor Author

/retest

@aarongalang
Copy link
Contributor Author

/retest

@aarongalang aarongalang changed the title WIP Improved Unit-Test Coverage for Issue #703 Improved Unit-Test Coverage for Issue #703 Aug 20, 2022
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 20, 2022
andyzhangx
andyzhangx approved these changes Aug 22, 2022
View reviewed changes
Copy link
Member

@andyzhangx andyzhangx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 22, 2022
@andyzhangx andyzhangx merged commit d0d8a03 into kubernetes-sigs:master Aug 22, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aarongalang, andyzhangx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mukhoakash mukhoakash mukhoakash left review comments

@andyzhangx andyzhangx andyzhangx approved these changes

@ZeroMagic ZeroMagic Awaiting requested review from ZeroMagic

Assignees

@andyzhangx andyzhangx

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/test lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aarongalang @k8s-ci-robot @mukhoakash @andyzhangx