Skip to content

feat: support data protection in account creation #815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 31, 2023
Merged

feat: support data protection in account creation #815

merged 1 commit into from
Jan 31, 2023

Conversation

cvvz
Copy link
Member

@cvvz cvvz commented Jan 13, 2023 •
edited
Loading

What type of PR is this?
/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #782

Requirements:

Special notes for your reviewer:

Release note:

 support data protection

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 13, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @cvvz. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 13, 2023
@cvvz cvvz marked this pull request as draft January 13, 2023 03:27
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 13, 2023
andyzhangx
andyzhangx reviewed Jan 13, 2023
View reviewed changes
Copy link
Member

@andyzhangx andyzhangx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 13, 2023
github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 13, 2023
View reviewed changes
github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 13, 2023
View reviewed changes
@cvvz cvvz marked this pull request as ready for review January 18, 2023 08:21
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 18, 2023
@cvvz cvvz marked this pull request as draft January 18, 2023 08:50
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 18, 2023
@cvvz cvvz marked this pull request as ready for review January 18, 2023 12:08
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 18, 2023
andyzhangx
andyzhangx reviewed Jan 28, 2023
View reviewed changes
github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 29, 2023
View reviewed changes
@andyzhangx andyzhangx changed the title feat: support data protection feat: support data protection in account creation Jan 30, 2023
andyzhangx
andyzhangx reviewed Jan 30, 2023
View reviewed changes
Copy link
Member

@andyzhangx andyzhangx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
pls squash all commits

@cvvz
Copy link
Member Author

cvvz commented Jan 30, 2023

/retest

@cvvz
Squashed commit of the following:
4331edd 
commit 0a0008c
Author: weizhichen <[email protected]>
Date:   Sun Jan 29 04:42:11 2023 +0000

    fix

commit 3424d96
Author: weizhichen <[email protected]>
Date:   Sun Jan 29 04:35:16 2023 +0000

    fix

commit 821889e
Author: weizhichen <[email protected]>
Date:   Sun Jan 29 04:13:30 2023 +0000

    fix

commit 5729f25
Author: weizhichen <[email protected]>
Date:   Sun Jan 29 03:04:48 2023 +0000

    fix by code review

commit e6e82de
Author: weizhichen <[email protected]>
Date:   Fri Jan 20 13:14:32 2023 +0000

    fix

commit c850aa1
Author: weizhichen <[email protected]>
Date:   Fri Jan 20 00:40:00 2023 +0000

    fix

commit 1a96e4f
Author: weizhichen <[email protected]>
Date:   Wed Jan 18 12:58:24 2023 +0000

    fix

commit f8d357a
Author: weizhichen <[email protected]>
Date:   Wed Jan 18 12:08:17 2023 +0000

    update cloud-provider-azure

commit 47a83ca
Author: weizhichen <[email protected]>
Date:   Wed Jan 18 08:21:18 2023 +0000

    update cloud-provider-azure

commit 000dd89
Author: weizhichen <[email protected]>
Date:   Tue Jan 17 09:34:39 2023 +0000

    fix CodeQL

commit 53e3f45
Author: weizhichen <[email protected]>
Date:   Tue Jan 17 08:56:58 2023 +0000

    fix

commit 048ccd2
Author: weizhichen <[email protected]>
Date:   Fri Jan 13 13:43:40 2023 +0000

    fix

commit 0eaf554
Author: weizhichen <[email protected]>
Date:   Fri Jan 13 11:33:02 2023 +0000

    fix

commit 342f0aa
Author: weizhichen <[email protected]>
Date:   Fri Jan 13 08:57:44 2023 +0000

    change isEnableBlobVersioning from bool to *bool

commit 90fdb32
Author: weizhichen <[email protected]>
Date:   Fri Jan 13 04:31:39 2023 +0000

    fix

commit ddefb2f
Author: weizhichen <[email protected]>
Date:   Fri Jan 13 03:16:49 2023 +0000

    feat: support data protection
@cvvz cvvz force-pushed the support-data-protection branch from 0a0008c to 4331edd Compare January 30, 2023 15:29
andyzhangx
andyzhangx approved these changes Jan 31, 2023
View reviewed changes
Copy link
Member

@andyzhangx andyzhangx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 31, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, cvvz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 31, 2023
@k8s-ci-robot k8s-ci-robot merged commit 5fc1e0a into kubernetes-sigs:master Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyzhangx andyzhangx andyzhangx approved these changes

@ZeroMagic ZeroMagic Awaiting requested review from ZeroMagic

Assignees

@andyzhangx andyzhangx

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ability to enable soft delete for blob and containers as well as enable versioning
3 participants
@cvvz @k8s-ci-robot @andyzhangx