-
Notifications
You must be signed in to change notification settings - Fork 96
🌱 Fix linter for the e2e test packages #718
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi @dmvolod. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
✅ Deploy Preview for kubernetes-sigs-cluster-api-operator ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice cleanup, thank you!
/approve
/lgtm
LGTM label has been added. Git tree hash: 3e768bd9459617e7f1a2cb8e3b0cca0128beb6fb
|
/approve cancel @dmvolod can you re-check the e2e tests, it looks like they are currently broken. |
Yes, sure @furkatgofurov7 , will look into it |
1611b36
to
46144ca
Compare
46144ca
to
f121a9a
Compare
f121a9a
to
c56de04
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks a lot!
/approve
/lgtm
LGTM label has been added. Git tree hash: db7b6438169dcf9504badba37a7588e7838ec100
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alexander-demicev The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
This fix linter issues for the e2e test packages. Able to run
make lint
andmake lint-fix
now.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #