🐛 avoid empty manager field in ControlPlaneProvider when no controlPlane and no features gates provided

[afarbos]

Following #681

What this PR does / why we need it:

Handle cases where manager values is present for default controlPlane provider.
This will make sure the manager field for the default control plane provider is added only if featureGates for this one are present when no controlPlane is provided (despite calling it out in the previous example).
The default controlPlane provider being kubeadm

The last part was the miss of #681

Example with current/v0.17.0 chart:

# Source: cluster-api-operator/charts/cluster-api-operator/templates/infra-conditions.yaml
apiVersion: operator.cluster.x-k8s.io/v1alpha2
kind: ControlPlaneProvider
metadata:
  name: kubeadm
  namespace: capi-kubeadm-control-plane-system
  annotations:
    "helm.sh/hook": "post-install,post-upgrade"
    "helm.sh/hook-weight": "2"
    "argocd.argoproj.io/sync-wave": "2"
spec:
  manager:

Similar error for InfrastructureProvider and there is no workaround for metal3. I tried to set a featuregates foo true to have a valid infrastructure provider but I get this error:

unknown flag: --feature-gates
Usage of /manager:
unknown flag: --feature-gates

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

[k8s-ci-robot]

Hi @afarbos. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[netlify]

✅ Deploy Preview for kubernetes-sigs-cluster-api-operator ready!

Name	Link
🔨 Latest commit	b344000
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-sigs-cluster-api-operator/deploys/67d32561367b4d0008765e30
😎 Deploy Preview	https://deploy-preview-735--kubernetes-sigs-cluster-api-operator.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[furkatgofurov7]

/ok-to-test

[furkatgofurov7]

/test pull-cluster-api-operator-e2e-main

[afarbos]

I am not sure to follow the failure but I did found more issues like this.

[afarbos]

/retest

[afarbos]

🎉 all green!

[alexander-demicev]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexander-demicev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [alexander-demicev]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[Danil-Grigorev]

/lgtm

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: b7fe03211d6d32005142eeb0c77ec5ea76bcc59c