-
Notifications
You must be signed in to change notification settings - Fork 96
🐛 Improve deployment with Argocd by allowing to remove helm hooks #751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi @afarbos. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
✅ Deploy Preview for kubernetes-sigs-cluster-api-operator ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
/ok-to-test cc @dtzar would it be possible to test this patch before we take it in? |
78c20ac
to
79c05e7
Compare
til |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
please, squash commits
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alexander-demicev The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
LGTM pending squash |
2e05fb1
to
5ea7523
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @afarbos!
/lgtm
LGTM label has been added. Git tree hash: ef75e9cc63b2d2d8c20d390c1b09f85eda1bfe03
|
What this PR does / why we need it:
Allow to disable have helm hooks. This help with argocd resource management (cannot autosync, no proper tracking of resources on deletion) and avoid deleting all hook resources each time we need to sync. This can be scary if the un-install does not work as expected and stuck the app state with no provider running.
Argocd automatically convert hooks from helm and there is no way to avoid that once those are set the resource will be considered deployed by a hook.
For reference here is the conversion: https://argo-cd.readthedocs.io/en/stable/user-guide/helm/#helm-hooks
By enabling the removal of helm hooks, argocd will still install the resource in the right order using the phase only ( https://argo-cd.readthedocs.io/en/stable/user-guide/sync-waves/#how-do-i-configure-waves )
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #562