Skip to content

🐛 InfrastructureProvider waiting for core provider even though CoreProvider is ready #756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 24, 2025
Merged

🐛 InfrastructureProvider waiting for core provider even though CoreProvider is ready #756

merged 2 commits into from
Mar 24, 2025

Conversation

dmvolod
Copy link
Member

@dmvolod dmvolod commented Mar 20, 2025

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #755

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 20, 2025
@netlify Netlify
Copy link

netlify bot commented Mar 20, 2025 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-cluster-api-operator ready!

Name Link
🔨 Latest commit d5d69f1
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-operator/deploys/67dd7e835de805000808d595
😎 Deploy Preview https://deploy-preview-756--kubernetes-sigs-cluster-api-operator.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@dmvolod dmvolod force-pushed the issue-755 branch 4 times, most recently from a0ad20c to a0611f4 Compare March 20, 2025 14:21
wahabmk
wahabmk reviewed Mar 20, 2025
View reviewed changes
@dmvolod dmvolod force-pushed the issue-755 branch 2 times, most recently from 94c7826 to ea10970 Compare March 21, 2025 12:45
@dmvolod dmvolod requested a review from wahabmk March 21, 2025 12:45
@dmvolod
Copy link
Member Author

dmvolod commented Mar 21, 2025

/help

@dmvolod
Copy link
Member Author

dmvolod commented Mar 21, 2025

/test pull-cluster-api-operator-test-main

@furkatgofurov7 furkatgofurov7 mentioned this pull request Mar 24, 2025
Closed
furkatgofurov7
furkatgofurov7 approved these changes Mar 24, 2025
View reviewed changes
Copy link
Member

@furkatgofurov7 furkatgofurov7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @dmvolod!

/approve

cc @wahabmk for a final review

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: furkatgofurov7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 24, 2025
Danil-Grigorev
Danil-Grigorev reviewed Mar 24, 2025
View reviewed changes
Copy link
Member

@Danil-Grigorev Danil-Grigorev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question about Ordered usage, otherwise lgtm

test/e2e/air_gapped_test.go
@@ -34,7 +34,7 @@ import (
"sigs.k8s.io/yaml"
)

var _ = Describe("Install Controlplane, Core, Bootstrap Providers in an air-gapped environment", func() {
var _ = Describe("Install Controlplane, Core, Bootstrap Providers in an air-gapped environment", Ordered, func() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
var _ = Describe("Install Controlplane, Core, Bootstrap Providers in an air-gapped environment", Ordered, func() {
var _ = Describe("Install Controlplane, Core, Bootstrap Providers in an air-gapped environment", func() {

What is the need for Ordered in here? These tests should be capable of running in parallel in any order, but if they need a prerequisite steps - please add it to the test case itself.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to tests are not designed to work independently. I fixed this bug and tests are failed without fixing order. I will try till make them independent or combine most of pipelines in the single It in next PR.

Danil-Grigorev
Danil-Grigorev reviewed Mar 24, 2025
View reviewed changes
internal/controller/genericprovider_controller.go
@@ -206,7 +206,7 @@ func (r *GenericProviderReconciler) reconcile(ctx context.Context, provider gene

if !res.IsZero() || err != nil {
// the steps are sequential, so we must be complete before progressing.
return res, err
return res, ignoreCoreProviderWaitError(err)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to confirm my understanding - are we ignoring the error because the reconciler of other providers is watching core provider for changes? So once the core provider is ready, it will surely retry without requeue caused by regular error propagation?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, exactly.

@Danil-Grigorev
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 24, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: b5c3822f3dc4b0ffd789b953443b449b8854b650

@k8s-ci-robot k8s-ci-robot merged commit 214e271 into kubernetes-sigs:main Mar 24, 2025
14 checks passed
@dmvolod
Copy link
Member Author

dmvolod commented Mar 24, 2025

/cherrypick release-0.17

@k8s-infra-cherrypick-robot
Copy link

@dmvolod: new pull request created: #761

In response to this:

/cherrypick release-0.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Mar 24, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Danil-Grigorev Danil-Grigorev Danil-Grigorev left review comments

@furkatgofurov7 furkatgofurov7 furkatgofurov7 approved these changes

@wahabmk wahabmk wahabmk approved these changes

@Fedosin Fedosin Awaiting requested review from Fedosin

@timothysc timothysc Awaiting requested review from timothysc

Assignees

@Danil-Grigorev Danil-Grigorev

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[bug] InfrastructureProvider waiting for core provider even though CoreProvider is ready
6 participants
@dmvolod @k8s-ci-robot @Danil-Grigorev @k8s-infra-cherrypick-robot @furkatgofurov7 @wahabmk