Skip to content

🐛 Fix appliedSpecHashAnnotation set if PreflightCheckPassed is not True #764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 1, 2025
Merged

🐛 Fix appliedSpecHashAnnotation set if PreflightCheckPassed is not True #764

merged 1 commit into from
Apr 1, 2025

Conversation

dmvolod
Copy link
Member

@dmvolod dmvolod commented Mar 30, 2025 •
edited
Loading

What this PR does / why we need it:
Added fix and test for it, as this case (create not Ready CoreProvider before or after other providers) never been tested.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #755

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 30, 2025
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 30, 2025
@netlify Netlify
Copy link

netlify bot commented Mar 30, 2025 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-cluster-api-operator ready!

Name Link
🔨 Latest commit e166d19
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-operator/deploys/67e98d0ce03cdd0008fda719
😎 Deploy Preview https://deploy-preview-764--kubernetes-sigs-cluster-api-operator.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@dmvolod dmvolod changed the title 🐛 Fix appliedSpecHashAnnotation set if PreflightCheckPassed is no… 🐛 Fix appliedSpecHashAnnotation set if PreflightCheckPassed is not True Mar 30, 2025
@dmvolod dmvolod force-pushed the issue-755-test-and-fix branch from 9a93809 to e166d19 Compare March 30, 2025 18:27
furkatgofurov7
furkatgofurov7 reviewed Apr 1, 2025
View reviewed changes
@furkatgofurov7 furkatgofurov7 added the kind/bug Categorizes issue or PR as related to a bug. label Apr 1, 2025
furkatgofurov7
furkatgofurov7 approved these changes Apr 1, 2025
View reviewed changes
Copy link
Member

@furkatgofurov7 furkatgofurov7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: furkatgofurov7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 1, 2025
@furkatgofurov7
Copy link
Member

Latest operator version v0.18.0 is broken due to this and we will need to cherry-pick (we need kubernetes/test-infra#34635 first) it to latest branch and release as next operator patch release v0.18.1

@Danil-Grigorev
Copy link
Member

/cherry-pick release-0.18

@k8s-infra-cherrypick-robot
Copy link

@Danil-Grigorev: once the present PR merges, I will cherry-pick it on top of release-0.18 in a new PR and assign it to you.

In response to this:

/cherry-pick release-0.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Danil-Grigorev
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 1, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: dd0925ef28b730943b7023912629bc381e59cbfc

@k8s-ci-robot k8s-ci-robot merged commit f275e2b into kubernetes-sigs:main Apr 1, 2025
14 checks passed
@k8s-infra-cherrypick-robot
Copy link

@Danil-Grigorev: new pull request created: #777

In response to this:

/cherry-pick release-0.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Apr 1, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@furkatgofurov7 furkatgofurov7 furkatgofurov7 approved these changes

@alexander-demicev alexander-demicev Awaiting requested review from alexander-demicev

@justinsb justinsb Awaiting requested review from justinsb

Assignees

@Danil-Grigorev Danil-Grigorev

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[bug] InfrastructureProvider waiting for core provider even though CoreProvider is ready
5 participants
@dmvolod @k8s-ci-robot @furkatgofurov7 @Danil-Grigorev @k8s-infra-cherrypick-robot