-
Notifications
You must be signed in to change notification settings - Fork 96
🌱 Bump golangci-lint to v2 #779
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Bump golangci-lint to v2 #779
Conversation
Signed-off-by: Andrea Mazzotti <[email protected]>
Welcome @anmazzotti! |
Hi @anmazzotti. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
✅ Deploy Preview for kubernetes-sigs-cluster-api-operator ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @anmazzotti
/approve
/lgtm
LGTM label has been added. Git tree hash: 7446d2325160502b5af87b22d3f2360f27d253d1
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: furkatgofurov7 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
This bumps the golangci-lint version to v2.
Should address and deprecate #766
The new config was migrated.
I replicated the comments in the migrated version.
Also note that I added some exclusion rules:
ST1016
andST1003
only apply toapi/
files, for convenience with the conversions code readability.ST1000
I do not find that useful personally.QF1008
I do like, but there were too many instances to fix and I don't know what the consensus is, so I excluded it before making too many changes to the codebase.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #