✨ Add AdditionalArgs field to API for custom provider settings #782
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/L
✅ Deploy Preview for kubernetes-sigs-cluster-api-operator ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Fedosin
force-pushed
the
additional-options
branch
from
2e3e4ba to
3482300
Compare
Fedosin
changed the title
Currently operator's API only allows to set common, most popular provider options. But sometimes it is necessary to specify non-standard options that the operator is not aware about. To do this we add a new API field called "AdditionalOptions" of type map[string]string. Every key there will be attached to provider's starting command.
Fedosin
force-pushed
the
additional-options
branch
from
3482300 to
18e9174
Compare
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: d3ad366536e55aa5b00ebb4b35ff80e8b1eb8b01
|
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alexander-demicev The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The operator API previously supported only a predefined set of common provider options. This limited flexibility when working with less common or provider-specific configurations.
To address this, a new field AdditionalArgs of type map[string]string is introduced. Each key-value pair in this map will be passed directly to the provider’s startup command, enabling users to specify arbitrary flags or environment parameters not explicitly handled by the operator.
This change enhances extensibility without requiring frequent operator updates for niche use cases.
Fixes #587