-
Notifications
You must be signed in to change notification settings - Fork 96
🌱 Fix spelling in controller metrics config description #809
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Fix spelling in controller metrics config description #809
Conversation
Welcome @hajowieland! |
Hi @hajowieland. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
✅ Deploy Preview for kubernetes-sigs-cluster-api-operator ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
/ok-to-test Thanks! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: furkatgofurov7 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
LGTM label has been added. Git tree hash: 4afbbf7b4ccc448e9ec58575dbe1a0e4393be211
|
/retest |
/test all |
/retest |
I needed to add the updated CRDs by running |
/retest |
@hajowieland can you run Edit: please also squash all commits, thanks! |
feat: update CRDs via make generate feat: generate full chart install manifest
19a25ed
to
45c1b9a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM label has been added. Git tree hash: cca317416dbc7f9d6f924a667fbeb013d0ab1a27
|
What this PR does / why we need it:
Mini spelling fix for the description of the controller metrics configuration.