Skip to content

🌱 Pass global concurrency number to manager #812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Danil-Grigorev
Copy link
Member

@Danil-Grigorev Danil-Grigorev commented May 7, 2025

What this PR does / why we need it:

This PR slightly improves memory footprint of the operator by implementing minor adjustments to the code:

  • Skip components.yaml caching in upgrade scenario for all other providers except upgraded. Only metadata.yaml is important there.
  • Pass concurrency number to the manager instance, allowing max X concurrent reconciles across different providers.
  • Increases memory limits to 300Mi from 150Mi, since in current setup azure provider alone is able to bump memory usage to median of ~130Mi.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 7, 2025
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 7, 2025
Copy link

netlify bot commented May 7, 2025

Deploy Preview for kubernetes-sigs-cluster-api-operator ready!

Name Link
🔨 Latest commit 29b2cec
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-operator/deploys/682496dca2fc9a00081039e5
😎 Deploy Preview https://deploy-preview-812--kubernetes-sigs-cluster-api-operator.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Danil-Grigorev Danil-Grigorev force-pushed the config-map-cache-hash branch 3 times, most recently from 02a28a4 to a99faa3 Compare May 12, 2025 13:41
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 13, 2025
@Danil-Grigorev Danil-Grigorev force-pushed the config-map-cache-hash branch 2 times, most recently from 27e84a2 to 35d581a Compare May 13, 2025 16:12
@Danil-Grigorev Danil-Grigorev force-pushed the config-map-cache-hash branch from 35d581a to c65fe46 Compare May 13, 2025 18:59
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels May 13, 2025
@Danil-Grigorev Danil-Grigorev changed the title [WIP] Calculate and compare provider configMap cache before reconcile 🌱 Pass global concurrency number to manager May 13, 2025
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 13, 2025
@Danil-Grigorev Danil-Grigorev force-pushed the config-map-cache-hash branch from a92be23 to 29b2cec Compare May 14, 2025 13:12
@Danil-Grigorev Danil-Grigorev moved this to PR to be reviewed in CAPI / Turtles May 14, 2025
Copy link
Member

@furkatgofurov7 furkatgofurov7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general improvements make sense to me, thanks for the PR.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 15, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: ea6996ac58ab871051408514bd8ca370e3e2ba76

Copy link
Contributor

@alexander-demicev alexander-demicev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexander-demicev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 15, 2025
@k8s-ci-robot k8s-ci-robot merged commit e25be4d into kubernetes-sigs:main May 15, 2025
14 checks passed
@github-project-automation github-project-automation bot moved this from PR to be reviewed to Done in CAPI / Turtles May 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants