-
Notifications
You must be signed in to change notification settings - Fork 96
🌱 Make namespace creation optional and configurable per component #813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Make namespace creation optional and configurable per component #813
Conversation
Welcome @fariaass! |
Hi @fariaass. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
✅ Deploy Preview for kubernetes-sigs-cluster-api-operator ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
e25a5c5
to
8507f0c
Compare
/ok-to-test |
Hey guys! How are you doing? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Having a self-contained chart to me looks more favorable where the chart manages everything needed, however, I do understand also the use cases where it should be optional and that is useful, since at the end of the day the default behaviour is staying the same (we always create ns unless it is explicitly set not to do so) after this change, so I am fine with the change.
/lgtm
LGTM label has been added. Git tree hash: bd1d571b57b8b104da9e5c48beb3affa05e028ee
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alexander-demicev The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
This PR adds the option to choose whether to create namespaces together the providers or not while helm chart installing. It makes the option configurable per component.