-
Notifications
You must be signed in to change notification settings - Fork 96
✨ add fetchConfig support to IPAMProvider in chart #817
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ add fetchConfig support to IPAMProvider in chart #817
Conversation
Welcome @manetherenio! |
Hi @manetherenio. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
✅ Deploy Preview for kubernetes-sigs-cluster-api-operator ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @manetherenio!
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: furkatgofurov7 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM label has been added. Git tree hash: 840081828830b8b9a6e4aa71f631ad45c5238137
|
What this PR does / why we need it:
While attempting to perform an air-gapped installation of the cluster-api operator using in-cluster IPAM, the helm chart does not utilize fetchConfig for the IPAMProvider CR, so there isn't a way to point the IPAM container to anything other than registry.k8s.io/capi-ipam-ic/cluster-api-ipam-in-cluster-controller:v1.0.1. Since I am trying to point all containers towards a local registry, I need to have the IPAMProvider fetch a LAN-located config which will point towards the disconnected container registry instead of generating its own. The IPAMProvider CRD already supports this, it just needs an update to the Helm chart to allow it to work properly.
Basically extending these steps:
https://cluster-api-operator.sigs.k8s.io/03_topics/02_configuration/01_air-gapped-environtment.html?highlight=air-gap#air-gapped-environment
But for the IPAM provider as well as the Infrastructure provider.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #