Skip to content

Enable additional linters #2414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sedefsavas opened this issue May 19, 2021 · 6 comments · Fixed by #2431
Closed

Enable additional linters #2414

sedefsavas opened this issue May 19, 2021 · 6 comments · Fixed by #2431
Assignees
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

Comments

@sedefsavas
Copy link
Contributor

Core cluster-api repo is enabling some additional linters, it'd be good for consistency to enable same linters.

kubernetes-sigs/cluster-api#4622

/help
/good-first-issue
/milestone 0.7.x

@k8s-ci-robot
Copy link
Contributor

@sedefsavas:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

Core cluster-api repo is enabling some additional linters, it'd be good for consistency to enable same linters.

kubernetes-sigs/cluster-api#4622

/help
/good-first-issue
/milestone 0.7.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

@sedefsavas: The provided milestone is not valid for this repository. Milestones in this repository: [Next, v0.6.x, v0.7.0, v0.7.x]

Use /milestone clear to clear the milestone.

In response to this:

Core cluster-api repo is enabling some additional linters, it'd be good for consistency to enable same linters.

kubernetes-sigs/cluster-api#4622

/help
/good-first-issue
/milestone 0.7.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels May 19, 2021
@Evalle
Copy link
Contributor

Evalle commented May 20, 2021

Hi @sedefsavas I can help with this. Any specific linters that you want to enable?
Thanks!

@sedefsavas
Copy link
Contributor Author

There are couple of PRs open in cluster-api. We can keep an eye on those: kubernetes-sigs/cluster-api#4622 and enable same ones.

Some relevant ones:
kubernetes-sigs/cluster-api#4649
kubernetes-sigs/cluster-api#4657

/assign @Evalle

@sbueringer
Copy link
Member

Just fyi. I try to keep an up-to-date list here: kubernetes-sigs/cluster-api#4622 for further inspiration. In general it might also make sense to compare the currently active linters in CAPI vs CAPA.

@sedefsavas
Copy link
Contributor Author

I created a new issue for enabling comment enforcement linter, as it will be big change.
#2428

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
Projects
None yet
4 participants