-
Notifications
You must be signed in to change notification settings - Fork 600
Add AWSClusterTemplate type #2575
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
FYI When implementing this please make sure that the template type applies the same defaulting & validation rules of the actual type, otherwise this could trigger continuous reconcile loop down the path when comparing the desired state (the AWSClusterTemplate object) with the actual state (the instance of AWSCluster generated from the template) |
/assign |
@Ankitasw Since you are already interested in this can you please review the PR :) |
PR: #2585 |
@ykakarap oh, that's ok if you have raised a PR, I will review it. I was about to raise a PR today, anyways just for future, please check the assignee in the issue before raising the PR, other people in community also want to work on ClusterClass 😅 |
/unassign |
You are completely correct. |
/assign Assigning now to avoid further confusion. /lifecycle active |
/kind feature
Describe the solution you'd like:
Add a new CRD named AWSClusterTemplate. This is needed for ClusterClass.
In the short term this type will not be used outside of ClusterClass.
The text was updated successfully, but these errors were encountered: