Skip to content

Add AWSClusterTemplate type #2575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ykakarap opened this issue Jul 8, 2021 · 8 comments · Fixed by #2585
Closed

Add AWSClusterTemplate type #2575

ykakarap opened this issue Jul 8, 2021 · 8 comments · Fixed by #2585
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. needs-priority

Comments

@ykakarap
Copy link

ykakarap commented Jul 8, 2021

/kind feature

Describe the solution you'd like:
Add a new CRD named AWSClusterTemplate. This is needed for ClusterClass.
In the short term this type will not be used outside of ClusterClass.

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. needs-priority labels Jul 8, 2021
@fabriziopandini
Copy link
Member

FYI When implementing this please make sure that the template type applies the same defaulting & validation rules of the actual type, otherwise this could trigger continuous reconcile loop down the path when comparing the desired state (the AWSClusterTemplate object) with the actual state (the instance of AWSCluster generated from the template)

@Ankitasw
Copy link
Member

/assign

@ykakarap
Copy link
Author

@Ankitasw
I am sorry I didnt realize you already had this issue assigned to you. I just opened a PR for this while I was working on similar PRs for other providers. Sorry for that.

Since you are already interested in this can you please review the PR :)

@ykakarap
Copy link
Author

PR: #2585

@Ankitasw
Copy link
Member

Ankitasw commented Jul 16, 2021

@ykakarap oh, that's ok if you have raised a PR, I will review it. I was about to raise a PR today, anyways just for future, please check the assignee in the issue before raising the PR, other people in community also want to work on ClusterClass 😅

@Ankitasw
Copy link
Member

/unassign

@ykakarap
Copy link
Author

You are completely correct.
I thought I assigned the issue when I created it.
I should have double checked. My bad. 😅

@ykakarap
Copy link
Author

ykakarap commented Jul 16, 2021

/assign

Assigning now to avoid further confusion.

/lifecycle active

@k8s-ci-robot k8s-ci-robot added the lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. label Jul 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. needs-priority
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants