Skip to content

add AWSClusterTemplate type #2585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 19, 2021

Conversation

ykakarap
Copy link

@ykakarap ykakarap commented Jul 15, 2021

What type of PR is this?
/kind feature
/kind api-change

What this PR does / why we need it:
This PR adds AWSClusterTemplate type. This type is need by the ClusterClass proposal.
In the near future this type would only be used by ClusterClass.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #2575

Special notes for your reviewer:

Checklist:

  • squashed commits
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

Release note:

Add AWSClusterTemplate type, to be used in managed cluster topologies (ClusterClass)

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority labels Jul 15, 2021
@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jul 15, 2021
@ykakarap ykakarap force-pushed the awsclustertemplate branch from ccbc42f to 51164fb Compare July 15, 2021 21:56
@shivi28
Copy link
Contributor

shivi28 commented Jul 16, 2021

Thanks @ykakarap for the PR ,
Run make generate some tests are failing. It is always advisable to run it before raising any PR.

@ykakarap
Copy link
Author

ykakarap commented Jul 16, 2021

@shivi28 I did run make generate before submitting the PR.
Similarly make verify runs successfully on my local. The same issue is surfacing on PRs for other providers too.

The issue seems to be that the generated files on the pipeline are adding a extra //go:build !ignore_autogenerated at the top of the zz_generate.deepcopy.go files.
This happened on rerunning the same pipeline on the same code that previously passed the verification pipeline. With this information I suspect that something about the pipelines changed and it might not be an issue with the code.

I dont know what is causing this, needs more investigation.

@shivi28
Copy link
Contributor

shivi28 commented Jul 16, 2021

Ya even I tried make generate on this PR and nothing changed.
This looks like a CI issue only. Another thread going on for this discussion kubernetes-sigs/cluster-api#4903 (comment)

@ykakarap
Copy link
Author

This looks like a CI issue only.

Yes

@randomvariable
Copy link
Member

@ykakarap
Copy link
Author

/retest

@ykakarap
Copy link
Author

/assign @randomvariable

@randomvariable
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 19, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: randomvariable

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 19, 2021
@randomvariable
Copy link
Member

/priority important-soon

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority labels Jul 19, 2021
@k8s-ci-robot k8s-ci-robot merged commit 33c9ef9 into kubernetes-sigs:main Jul 19, 2021
@k8s-ci-robot k8s-ci-robot added this to the v0.7.0 milestone Jul 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add AWSClusterTemplate type
4 participants