[release-1.5] feat: external load balancer garbage collection (part 3) - add gc to reconciliation #3646
Conversation
This change uses the new garbage collection service enables this during the reconciliation of `AWSCluster` and `AWSManagedControlPlane`. Its enabled via a new feature flag `ExternalResourceGC` which is disabled by default. If the feature flag is enabled then the the gc service is called in `reconcileDelete` for the infra clusters. The actual gc service does the work of cleanup. New commands have been added to `clusterawsadm` to allow users to opt-in/out an already existing cluster from garbage collection. Additionally, with the new mocks folder introduced with the gc service the existing mocks have been deleted and tests/controllers updated. Signed-off-by: Richard Case <[email protected]>
Various changes as a result of review feedback. Signed-off-by: Richard Case <[email protected]>
k8s-ci-robot
added
cncf-cla: yes
|
@k8s-infra-cherrypick-robot: This issue is currently awaiting triage. If CAPA/CAPI contributors determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
the
needs-triage
k8s-ci-robot
added
the
size/XXL
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: richardcase The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
This is an automated cherry-pick of #3633
/assign richardcase