✨ Migrate S3, Sessions and Endpoints packages to AWS SDK v2

[punkwalker]

What type of PR is this?
/kind feature
/kind cleanup

What this PR does / why we need it:
It is initial aws-sdk-go-v2 migration for few components. This PR only migrates S3 Client to V2.
I have created this PR as a duplicate of #5272 as @mjlshen does not have cycles to work on it. So I will be working on this migration going forward. I wanted to make sure we get quicker review on this migration PRs.

Which issue(s) this PR fixes:
Fixes: #5400
Fixes: #5414

Special notes for your reviewer:
This migration will require multiple such PRs. It would be great if we can get some thoughts on the approach of this migration. It might be missing some test cases for V2 clients but we will add it as we go along.

Checklist:

• squashed commits
• includes documentation
• includes emoji in title
• adds unit tests
• adds or updates e2e tests

Release note:

Migrate the S3 service to aws-sdk-go-v2

[k8s-ci-robot]

Welcome @punkwalker!

It looks like this is your first PR to kubernetes-sigs/cluster-api-provider-aws 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-api-provider-aws has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @punkwalker. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[faiq]

/ok-to-test

[nrb]

Awesome, thank you @punkwalker! This is super valuable but not flashy work.

I agree that we'll need to do this in multiple PRs.

Maybe we should come up with a checklist of areas that would be logically separate and put that checklist in #2225? We could also create separate issues for each, if we think this spans releases. We can discuss at the next community meeting on Monday, 17 March?

[nrb]

From community call on March 17:

• Identity and sessions were changed in this PR, but should be a smaller change going forward, since it's already done.
• We'll break up work by service in pkg/cloud/services/
• Need to make sure logging messages are the same, regardless of middleware implementation.

[richardcase]

/test ?

[k8s-ci-robot]

@richardcase: The following commands are available to trigger required jobs:

/test pull-cluster-api-provider-aws-build

/test pull-cluster-api-provider-aws-build-docker

/test pull-cluster-api-provider-aws-test

/test pull-cluster-api-provider-aws-verify

The following commands are available to trigger optional jobs:

/test pull-cluster-api-provider-aws-apidiff-main

/test pull-cluster-api-provider-aws-e2e

/test pull-cluster-api-provider-aws-e2e-blocking

/test pull-cluster-api-provider-aws-e2e-clusterclass

/test pull-cluster-api-provider-aws-e2e-conformance

/test pull-cluster-api-provider-aws-e2e-conformance-with-ci-artifacts

/test pull-cluster-api-provider-aws-e2e-eks

/test pull-cluster-api-provider-aws-e2e-eks-gc

/test pull-cluster-api-provider-aws-e2e-eks-testing

Use /test all to run the following jobs that were automatically triggered:

pull-cluster-api-provider-aws-apidiff-main

pull-cluster-api-provider-aws-build

pull-cluster-api-provider-aws-build-docker

pull-cluster-api-provider-aws-test

pull-cluster-api-provider-aws-verify

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[richardcase]

/test pull-cluster-api-provider-aws-test
/test pull-cluster-api-provider-aws-e2e-eks

[punkwalker]

@richardcase Apologies, I did not get the notification for your message as I had lost access to my GitHub email.
Looks like the tests are passing but I am going to take another look at the changes to ensure we are not changing any middleware behavior with V2 SDK.

[punkwalker]

/test pull-cluster-api-provider-aws-e2e-eks

[punkwalker]

@richardcase The PR is Ready. Please let me know if you want me to make any changes. Thank You 🙇‍♂️

[richardcase]

/test pull-cluster-api-provider-aws-e2e

[richardcase]

/test pull-cluster-api-provider-aws-e2e
/test pull-cluster-api-provider-aws-e2e-eks

[nrb]

/lgtm

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: 0765cb4b6f5809d1a89d1bae400a6dc7c1aabd1f

[richardcase]

Thanks for this @punkwalker .

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: richardcase

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [richardcase]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment