Skip to content

Remove kind get kubeconfig-path references in makefile and getting-started scripts #355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
CecileRobertMichon opened this issue Jan 7, 2020 · 7 comments · Fixed by #358
Closed

Remove kind get kubeconfig-path references in makefile and getting-started scripts #355

CecileRobertMichon opened this issue Jan 7, 2020 · 7 comments · Fixed by #358
Assignees
@nader-ziada
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

Comments

@CecileRobertMichon
Copy link
Contributor

kind get kubeconfig-path is deprecated.

See kubernetes-sigs/kind#1060 for details.

kubectl \
		--kubeconfig=$(kind get kubeconfig-path --name="clusterapi") \
		create -f examples/_out/controlplane.yaml
`kind get kubeconfig-path` is deprecated!

KIND will export and merge kubeconfig like kops, minikube, etc.
This command is now unnecessary and will be removed in a future release.
@CecileRobertMichon
Copy link
Contributor Author

@rbitia do you want to take this one?

@nader-ziada
Copy link
Contributor

This is the similar issue in cluster-api main repo kubernetes-sigs/cluster-api#1796

@CecileRobertMichon
Copy link
Contributor Author

/help
/good-first-issue

@k8s-ci-robot
Copy link
Contributor

@CecileRobertMichon:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

/help
/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Jan 9, 2020
@nader-ziada
Copy link
Contributor

@CecileRobertMichon should this include bumping the MINIMUM_KIND_VERSION to 0.6?

@CecileRobertMichon
Copy link
Contributor Author

@nader-ziada yes

@nader-ziada
Copy link
Contributor

/assign

@nader-ziada nader-ziada mentioned this issue Jan 9, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nader-ziada nader-ziada

Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change kind min version to 0.6.1 nader-ziada/cluster-api-provider-azure
3 participants
@nader-ziada @CecileRobertMichon @k8s-ci-robot