disable external load balancer test #1123
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
k8s-ci-robot
added
the
sig/cluster-lifecycle
nader-ziada
reviewed
Jan 15, 2021
devigned
changed the title
k8s-ci-robot
added
size/M
| Expect(resp.StatusCode).To(Equal(200)) | ||
| Expect(err).NotTo(HaveOccurred()) | ||
| } | ||
| // TODO: determine root issue of failures of addressing the ELB from prow and fix |
There was a problem hiding this comment.
was deferring the delete not enough?
There was a problem hiding this comment.
No. Deferring was not enough. :(
We still run test the elb through the curl job and it succeeds, so at least we are not 100% blind.
CecileRobertMichon
approved these changes
Jan 15, 2021
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CecileRobertMichon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
Unrelated failure: |
|
/retest |
|
the IPv6 flake has been around for a while, doesn't happen super often :( |
This was referenced Jan 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind failing-test
What this PR does / why we need it:
Tests are failing for load balancers and it seems to happen when the cloud provider removes an internal load balancer from a VMSS and then quickly tries to update the VMSS with another load balancer. This PR disables the external load balancer test which tests connectivity from outside of the cluster. We still verify connectivity from a curl job inside of the cluster. A TODO has been added to re-enable.
Additional work is being done here: #1121
Special notes for your reviewer:
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
TODOs:
Release note: