Skip to content

bump KUBERNETES_VERSION + refactor loading #1476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

bump KUBERNETES_VERSION + refactor loading #1476

wants to merge 1 commit into from

Conversation

damdo
Copy link
Member

@damdo damdo commented May 16, 2025 •
edited
Loading

What type of PR is this?
/kind other

What this PR does / why we need it:

Bump KUBERNETES_VERSION for e2e CI tests + refactor loading of such version

Release note:

NONE

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 16, 2025
@netlify Netlify
Copy link

netlify bot commented May 16, 2025 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-cluster-api-gcp ready!

Name Link
🔨 Latest commit 5336c3b
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-sigs-cluster-api-gcp/deploys/68382c8fdc1ebb00082b87b9
😎 Deploy Preview https://deploy-preview-1476--kubernetes-sigs-cluster-api-gcp.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 16, 2025
@damdo
Copy link
Member Author

damdo commented May 16, 2025

/test pull-cluster-api-provider-gcp-e2e-test

@damdo damdo force-pushed the bump-k8s-version-and-refactor branch from 0c7037f to 52520dd Compare May 16, 2025 12:35
@damdo
Copy link
Member Author

damdo commented May 16, 2025

/test pull-cluster-api-provider-gcp-e2e-test

@damdo damdo marked this pull request as ready for review May 16, 2025 13:01
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 16, 2025
@k8s-ci-robot k8s-ci-robot requested a review from richardcase May 16, 2025 13:01
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels May 16, 2025
alexander-demicev
alexander-demicev approved these changes May 16, 2025
View reviewed changes
Copy link
Contributor

@alexander-demicev alexander-demicev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 16, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexander-demicev, damdo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@richardcase
Copy link
Member

@damdo - thanks for doing this 🎉 The solution looks good, just a couple of shell check issues need fixing.

@damdo damdo force-pushed the bump-k8s-version-and-refactor branch from 52520dd to b505178 Compare May 16, 2025 13:14
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 16, 2025
@richardcase
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 16, 2025
@damdo
Copy link
Member Author

damdo commented May 16, 2025

/test pull-cluster-api-provider-gcp-e2e-test

@richardcase
Copy link
Member

The server encountered a temporary error and could not complete your request.<p>Please try again in 30 seconds. 😬

/test pull-cluster-api-provider-gcp-e2e-test

@damdo
Copy link
Member Author

damdo commented May 16, 2025 •
edited
Loading

E0516 15:19:06.500450 1 gcpmachine_controller.go:228] "Error reconciling instance resources" err="googleapi: Error 403: Required 'compute.images.useReadOnly' permission for 'projects/k8s-staging-cluster-api-gcp/global/images/cluster-api-ubuntu-2204-v1-31-0-nightly', forbidden" controller="gcpmachine" controllerGroup="infrastructure.cluster.x-k8s.io" controllerKind="GCPMachine" GCPMachine="create-workload-cluster-3r20x7/capg-e2e-xzgrrm-control-plane-fmnxb" namespace="create-workload-cluster-3r20x7" name="capg-e2e-xzgrrm-control-plane-fmnxb" reconcileID="a6148041-262d-48f1-a446-11bf07978e34"

@damdo damdo force-pushed the bump-k8s-version-and-refactor branch from b505178 to 8ba6e51 Compare May 16, 2025 17:05
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 16, 2025
@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@damdo
Copy link
Member Author

damdo commented May 19, 2025

/test pull-cluster-api-provider-gcp-e2e-test

@damdo damdo mentioned this pull request May 19, 2025
Open
3 tasks
@damdo
Copy link
Member Author

damdo commented May 19, 2025

/test pull-cluster-api-provider-gcp-e2e-test

justinsb
justinsb reviewed May 22, 2025
View reviewed changes
hack/ensure-yq.sh Outdated
# Install yq only if not already installed
if ! [ -x "$(command -v yq)" ]; then
echo 'yq not found, installing'
go install "github.com/mikefarah/yq/v4@${YQ_VERSION}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Not a blocker)... IMO the overhead of go run is now negligible, and lets us more easily pin the version.

@damdo damdo force-pushed the bump-k8s-version-and-refactor branch from 8ba6e51 to 5336c3b Compare May 29, 2025 09:44
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 29, 2025
@k8s-ci-robot
Copy link
Contributor

@damdo: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-provider-gcp-e2e-test 5336c3b link true /test pull-cluster-api-provider-gcp-e2e-test

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@damdo
Copy link
Member Author

damdo commented May 29, 2025

Hm with this change I am getting:

I0529 10:03:19.086661       1 recorder.go:104] "Reconcile error - googleapi: Error 403: Required 'compute.images.useReadOnly' permission for 'projects/k8s-staging-cluster-api-gcp/global/images/cluster-api-ubuntu-2204-v1-32-0-nightly', forbidden" logger="events" type="Warning" object={"kind":"GCPMachine","namespace":"create-workload-cluster-rb6j1h","name":"capg-e2e-kuusrq-single-control-plane-lmltc","uid":"1953e96a-5272-4a2a-bd3d-50e6fff56bce","apiVersion":"infrastructure.cluster.x-k8s.io/v1beta1","resourceVersion":"1794"} reason="GCPMachineReconcile"
I0529 10:03:19.086667       1 recorder.go:104] "Reconcile error - googleapi: Error 403: Required 'compute.images.useReadOnly' permission for 'projects/k8s-staging-cluster-api-gcp/global/images/cluster-api-ubuntu-2204-v1-32-0-nightly', forbidden" logger="events" type="Warning" object={"kind":"GCPMachine","namespace":"create-workload-cluster-rb6j1h","name":"capg-e2e-kuusrq-single-control-plane-lmltc","uid":"1953e96a-5272-4a2a-bd3d-50e6fff56bce","apiVersion":"infrastructure.cluster.x-k8s.io/v1beta1","resourceVersion":"1794"} reason="GCPMachineReconcile"
E0529 10:03:19.086841       1 controller.go:347] "Reconciler error" err="googleapi: Error 403: Required 'compute.images.useReadOnly' permission for 'projects/k8s-staging-cluster-api-gcp/global/images/cluster-api-ubuntu-2204-v1-32-0-nightly', forbidden" controller="gcpmachine" controllerGroup="infrastructure.cluster.x-k8s.io" controllerKind="GCPMachine" GCPMachine="create-workload-cluster-rb6j1h/capg-e2e-kuusrq-single-control-plane-lmltc" namespace="create-workload-cluster-rb6j1h" name="capg-e2e-kuusrq-single-control-plane-lmltc" reconcileID="5c13afcc-25d9-438a-853d-3f5ff94d1871"

Not sure why the new image requires extra permissions 'compute.images.useReadOnly'.
Any idea @richardcase ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinsb justinsb justinsb left review comments

@alexander-demicev alexander-demicev alexander-demicev approved these changes

@dims dims Awaiting requested review from dims

@salasberryfin salasberryfin Awaiting requested review from salasberryfin

@richardcase richardcase Awaiting requested review from richardcase

Assignees

@richardcase richardcase

@alexander-demicev alexander-demicev

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@damdo @k8s-ci-robot @richardcase @justinsb @alexander-demicev