Skip to content

Secondary ranges for GCPManagedControlPlane #1480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 29, 2025

Conversation

cecilkootz
Copy link
Contributor

@cecilkootz cecilkootz commented May 27, 2025

What type of PR is this?
/kind feature

What this PR does / why we need it:
Allow passing the Pod.CidrBlock and Service.CidrBlock to GCPManagedControlPlane instances.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Expands #1027

Special notes for your reviewer:
Supersedes #1390

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests

Release note:

Fix a bug to support `secondyCidrBlocks` for GCPManagedControlPlane instances.

Allow passing the Pod.CidrBlock and Service.CidrBlock to GCPManagedControlPlane instances.
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 27, 2025
@k8s-ci-robot k8s-ci-robot requested review from damdo and richardcase May 27, 2025 17:13
Copy link

netlify bot commented May 27, 2025

Deploy Preview for kubernetes-sigs-cluster-api-gcp ready!

Name Link
🔨 Latest commit b1ba096
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-sigs-cluster-api-gcp/deploys/6835f2a3cec4dd0008adc7ea
😎 Deploy Preview https://deploy-preview-1480--kubernetes-sigs-cluster-api-gcp.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot
Copy link
Contributor

Hi @cecilkootz. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 27, 2025
Copy link
Member

@damdo damdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 28, 2025
@damdo
Copy link
Member

damdo commented May 28, 2025

/assign @salasberryfin

as you originally reviewed (#1390)

@salasberryfin
Copy link
Contributor

Thanks @cecilkootz, LGTM pending CI validation.

Just a quick question: my understanding is that, if these fields are left blank, GCP will select a default range but I haven't confirmed this behavior myself. Is this correct?

@cecilkootz
Copy link
Contributor Author

Thanks @cecilkootz, LGTM pending CI validation.

Just a quick question: my understanding is that, if these fields are left blank, GCP will select a default range but I haven't confirmed this behavior myself. Is this correct?

That's correct. Both require the use of UseIPAliases and if not set, a range will be automatically chosen with the default.

@salasberryfin
Copy link
Contributor

Thanks @cecilkootz.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 29, 2025
@salasberryfin
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cecilkootz, salasberryfin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 29, 2025
@k8s-ci-robot k8s-ci-robot merged commit a566ae6 into kubernetes-sigs:main May 29, 2025
24 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.1.0 milestone May 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants