-
Notifications
You must be signed in to change notification settings - Fork 214
Secondary ranges for GCPManagedControlPlane #1480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Secondary ranges for GCPManagedControlPlane #1480
Conversation
Allow passing the Pod.CidrBlock and Service.CidrBlock to GCPManagedControlPlane instances.
✅ Deploy Preview for kubernetes-sigs-cluster-api-gcp ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Hi @cecilkootz. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
/assign @salasberryfin as you originally reviewed (#1390) |
Thanks @cecilkootz, LGTM pending CI validation. Just a quick question: my understanding is that, if these fields are left blank, GCP will select a default range but I haven't confirmed this behavior myself. Is this correct? |
That's correct. Both require the use of |
Thanks @cecilkootz. /lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cecilkootz, salasberryfin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Allow passing the
Pod.CidrBlock
andService.CidrBlock
to GCPManagedControlPlane instances.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Expands #1027
Special notes for your reviewer:
Supersedes #1390
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
TODOs:
Release note: