use dl.k8s.io instead of hardcoded GCS URIs #399
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use dl.k8s.io instead of hardcoded GCS URIs
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
The only time a kubernetes GCS bucket name should be showing up in a
hardcoded URI is if
gsutil
is being used (e.g. gsutil cp gs://foo/bar .)Otherwise, for tools like
curl
orwget
, dl.k8s.io is much nicer for usas a project, since we can transparently change where that redirects to
without having to change code everywhere
These changes will mean no changes will be necessary to accommodate a
gs://kubernetes-release
->gs://k8s-release
migration equivalent ofthe CI migration we're going through right now
These changes also address the
gs://kubernetes-release-dev
referencescurrently used by this repo (ref:
kubernetes/k8s.io#2318)
Special notes for your reviewer:
I'm not sure that a release note is required for this, but I put one in
just in case
Similar / related PRs:
TODOs:
includes documentation(n/a)adds unit tests(n/a)Release note: