-
Notifications
You must be signed in to change notification settings - Fork 268
✨ Use kustomize new syntax for patches #1735
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Use kustomize new syntax for patches #1735
Conversation
✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Hi @mquhuy. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
b8fa601
to
7bab061
Compare
/ok-to-test |
7bab061
to
f178f68
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Could you move the apiVersion
and kind
to the top of the files?
f178f68
to
5ff0bf8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
5ff0bf8
to
83f22d4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lentzi90, mquhuy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Triggering full e2e since this touches the remediation tests |
It is unclear to me if the test failure is related to the PR |
/lgtm |
/unhold |
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #1730
Special notes for your reviewer:
Kustomize
version needs to be updated to 5.2.1, as the current version (5.1.1) gets confused with multiple objects in the same patch file (it only understands if the patch file is split so that each object is in one file).I also updated the kustomize version in
ensure_kustomize.sh
. Not sure if it's in use though, as I can see that the version is already very old.