only use loadbalaner reference if needed #978
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jichenjc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
size/S
k8s-ci-robot
added
the
approved
jichenjc
force-pushed
the
bug/974
branch
2 times, most recently
from
480a755 to
8bba5d8
Compare
tobiasgiese
reviewed
Aug 26, 2021
Comment on lines
376
to
380
| if openStackCluster.Spec.ManagedAPIServerLoadBalancer { | ||
| loadBalancerService, err = loadbalancer.NewService(osProviderClient, clientOpts, log) | ||
| if err != nil { | ||
| return err | ||
| } |
There was a problem hiding this comment.
I think it's enough to create the load balancer service inside the condition in l.473
There was a problem hiding this comment.
I.e., create the service right before we need it
jichenjc
force-pushed
the
bug/974
branch
2 times, most recently
from
05bab1d to
da1f9f3
Compare
k8s-ci-robot
added
size/M
tobiasgiese
reviewed
Sep 1, 2021
| @@ -365,18 +365,14 @@ func reconcileBastion(log logr.Logger, osProviderClient *gophercloud.ProviderCli | |||
| } | |||
|
|
|||
| func reconcileNetworkComponents(log logr.Logger, osProviderClient *gophercloud.ProviderClient, clientOpts *clientconfig.ClientOpts, cluster *clusterv1.Cluster, openStackCluster *infrav1.OpenStackCluster) error { | |||
| var loadBalancerService *loadbalancer.Service | |||
There was a problem hiding this comment.
You can remove the initialization, as it‘s only used once inside the condition :)
There was a problem hiding this comment.
right, forgot this ..
k8s-ci-robot
added
size/S
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #974
Special notes for your reviewer:
TODOs:
/hold