Skip to content

Commit 67ff129

Browse files
authored
Merge pull request #6638 from sbueringer/pr-runtimesdk-fixups
🐛 RuntimeSDK: some bugfixes
2 parents 9bfd3f3 + eeb7c11 commit 67ff129

File tree

4 files changed

+16
-2
lines changed

4 files changed

+16
-2
lines changed

config/rbac/role.yaml

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,14 @@ metadata:
55
creationTimestamp: null
66
name: manager-role
77
rules:
8+
- apiGroups:
9+
- ""
10+
resources:
11+
- namespaces
12+
verbs:
13+
- get
14+
- list
15+
- watch
816
- apiGroups:
917
- addons.cluster.x-k8s.io
1018
resources:

exp/runtime/internal/controllers/extensionconfig_controller.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@ import (
3636
)
3737

3838
// +kubebuilder:rbac:groups=runtime.cluster.x-k8s.io,resources=extensionconfigs;extensionconfigs/status,verbs=get;list;watch;patch;update
39+
// +kubebuilder:rbac:groups="",resources=namespaces,verbs=get;list;watch
3940

4041
// Reconciler reconciles an ExtensionConfig object.
4142
type Reconciler struct {

main.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -377,6 +377,7 @@ func setupReconcilers(ctx context.Context, mgr ctrl.Manager) {
377377
RuntimeClient: runtimeclient.New(runtimeclient.Options{
378378
Catalog: catalog,
379379
Registry: registry,
380+
Client: mgr.GetClient(),
380381
}),
381382
WatchFilterValue: watchFilterValue,
382383
}).SetupWithManager(ctx, mgr, concurrency(extensionConfigConcurrency)); err != nil {

test/e2e/cluster_upgrade_runtimesdk.go

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -227,8 +227,12 @@ func extensionConfig(specName string, namespace *corev1.Namespace) *runtimev1.Ex
227227
},
228228
},
229229
NamespaceSelector: &metav1.LabelSelector{
230-
MatchLabels: map[string]string{
231-
"kubernetes.io/metadata.name:": namespace.Name,
230+
MatchExpressions: []metav1.LabelSelectorRequirement{
231+
{
232+
Key: "kubernetes.io/metadata.name",
233+
Operator: metav1.LabelSelectorOpIn,
234+
Values: []string{namespace.Name},
235+
},
232236
},
233237
},
234238
},

0 commit comments

Comments
 (0)