Skip to content

🐛 RuntimeSDK: some bugfixes #6638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 13, 2022

Conversation

sbueringer
Copy link
Member

@sbueringer sbueringer commented Jun 13, 2022

What this PR does / why we need it:
This PR fixes some bugs which have been introduced by recent PRs:

  1. The ExtensionConfig controller need permissions to list namespaces
  2. The ExtensionConfig controller requires the client to be set in main.go otherwise we're getting a panic when we try to List namespaces
  3. We have to select the namespace via expressions as / is not allowed in the label selector

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 13, 2022
@fabriziopandini
Copy link
Member

lgtm pending comment above.
to use the const we need #6632 to merge first, which makes sense for me

@sbueringer sbueringer force-pushed the pr-runtimesdk-fixups branch from c2cc5be to eeb7c11 Compare June 13, 2022 16:28
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 13, 2022
@sbueringer
Copy link
Member Author

lgtm pending comment above. to use the const we need #6632 to merge first, which makes sense for me

Let's move the fix to #6632

@sbueringer
Copy link
Member Author

This PR should now be unblocked

@chrischdi
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 13, 2022
Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 13, 2022
@k8s-ci-robot k8s-ci-robot merged commit 67ff129 into kubernetes-sigs:main Jun 13, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.2 milestone Jun 13, 2022
@sbueringer sbueringer deleted the pr-runtimesdk-fixups branch June 13, 2022 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants