Skip to content

Deprecate ancient errors/ package #10784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
enxebre opened this issue Jun 19, 2024 · 0 comments · Fixed by #10798
Closed

Deprecate ancient errors/ package #10784

enxebre opened this issue Jun 19, 2024 · 0 comments · Fixed by #10798
Assignees
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/backlog Higher priority than priority/awaiting-more-evidence. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@enxebre
Copy link
Member

enxebre commented Jun 19, 2024

What would you like to be added (User Story)?

The /errors package has its origin in when capi providers were machineActuators that needed to vendor core capi to function.
There's no usage recommendations and value is questionable since we moved to CRDs and conditions for interoperability between core and providers.
I think we should deprecate it and if there's any use case relying on it we should support it via conditions

Detailed Description

The /errors package has its origin in when capi providers were machineActuators that needed to vendor core capi to function.
There's no usage recommendations and value is questionable since we moved to CRDs and conditions for interoperability between core and providers.
I think we should deprecate it and if there's any use case relying on it we should support it via conditions

Anything else you would like to add?

No response

Label(s) to be applied

/kind feature
One or more /area label. See https://github.com/kubernetes-sigs/cluster-api/labels?q=area for the list of labels.

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. needs-priority Indicates an issue lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jun 19, 2024
@enxebre enxebre changed the title Deprecate errors/consts.go Deprecate ancient errors/ package Jun 19, 2024
@fabriziopandini fabriziopandini added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/backlog Higher priority than priority/awaiting-more-evidence. and removed kind/feature Categorizes issue or PR as related to a new feature. labels Jul 3, 2024
@k8s-ci-robot k8s-ci-robot removed the needs-priority Indicates an issue lacks a `priority/foo` label and requires one. label Jul 3, 2024
@fabriziopandini fabriziopandini added lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. labels Jul 3, 2024
@k8s-ci-robot k8s-ci-robot removed the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Jul 3, 2024
EmilienM added a commit to shiftstack/cluster-api-provider-openstack that referenced this issue Nov 20, 2024
Context: kubernetes-sigs/cluster-api#10784
We'll maintain them here for the time being, until we have conditions
replacing these errors.
EmilienM added a commit to shiftstack/cluster-api-provider-openstack that referenced this issue Nov 20, 2024
Context: kubernetes-sigs/cluster-api#10784
We'll maintain them here for the time being, until we have conditions
replacing these errors.
EmilienM added a commit to shiftstack/cluster-api-provider-openstack that referenced this issue Nov 20, 2024
Context: kubernetes-sigs/cluster-api#10784
We'll maintain them here for the time being, until we have conditions
replacing these errors.
EmilienM added a commit to shiftstack/cluster-api-provider-openstack that referenced this issue Nov 20, 2024
Context: kubernetes-sigs/cluster-api#10784
We'll maintain them here for the time being, until we have conditions
replacing these errors.
EmilienM added a commit to shiftstack/cluster-api-provider-openstack that referenced this issue Nov 20, 2024
Context: kubernetes-sigs/cluster-api#10784
We'll maintain them here for the time being, until we have conditions
replacing these errors.
EmilienM added a commit to shiftstack/cluster-api-provider-openstack that referenced this issue Nov 20, 2024
Context: kubernetes-sigs/cluster-api#10784
We'll maintain them here for the time being, until we have conditions
replacing these errors.
EmilienM added a commit to shiftstack/cluster-api-provider-openstack that referenced this issue Nov 20, 2024
Context: kubernetes-sigs/cluster-api#10784
We'll maintain them here for the time being, until we have conditions
replacing these errors.
EmilienM added a commit to shiftstack/cluster-api-provider-openstack that referenced this issue Dec 11, 2024
Context: kubernetes-sigs/cluster-api#10784
We'll maintain them here for the time being, until we have conditions
replacing these errors.
EmilienM added a commit to shiftstack/cluster-api-provider-openstack that referenced this issue Dec 11, 2024
Context: kubernetes-sigs/cluster-api#10784
We'll maintain them here for the time being, until we have conditions
replacing these errors.
EmilienM added a commit to shiftstack/cluster-api-provider-openstack that referenced this issue Dec 11, 2024
Context: kubernetes-sigs/cluster-api#10784
We'll maintain them here for the time being, until we have conditions
replacing these errors.
EmilienM added a commit to shiftstack/cluster-api-provider-openstack that referenced this issue Dec 12, 2024
Context: kubernetes-sigs/cluster-api#10784
We'll maintain them here for the time being, until we have conditions
replacing these errors.
EmilienM added a commit to shiftstack/cluster-api-provider-openstack that referenced this issue Dec 17, 2024
Context: kubernetes-sigs/cluster-api#10784
We'll maintain them here for the time being, until we have conditions
replacing these errors.
EmilienM added a commit to shiftstack/cluster-api-provider-openstack that referenced this issue Dec 30, 2024
Context: kubernetes-sigs/cluster-api#10784
We'll maintain them here for the time being, until we have conditions
replacing these errors.
MaysaMacedo pushed a commit to shiftstack/cluster-api-provider-openstack that referenced this issue Dec 30, 2024
Context: kubernetes-sigs/cluster-api#10784
We'll maintain them here for the time being, until we have conditions
replacing these errors.
MaysaMacedo pushed a commit to shiftstack/cluster-api-provider-openstack that referenced this issue Jan 2, 2025
Context: kubernetes-sigs/cluster-api#10784
We'll maintain them here for the time being, until we have conditions
replacing these errors.
MaysaMacedo pushed a commit to shiftstack/cluster-api-provider-openstack that referenced this issue Jan 2, 2025
Context: kubernetes-sigs/cluster-api#10784
We'll maintain them here for the time being, until we have conditions
replacing these errors.
EmilienM added a commit to shiftstack/cluster-api-provider-openstack that referenced this issue Jan 9, 2025
Context: kubernetes-sigs/cluster-api#10784
We'll maintain them here for the time being, until we have conditions
replacing these errors.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/backlog Higher priority than priority/awaiting-more-evidence. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants