Skip to content

Tracking issue for Improving status in CAPI resources - Follow up from phase 1 #11474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
10 tasks done
fabriziopandini opened this issue Nov 25, 2024 · 3 comments
Closed
10 tasks done
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Milestone

Comments

@fabriziopandini
Copy link
Member

fabriziopandini commented Nov 25, 2024

This is a tracking issue for activities related to #10897
Phase 1 activities are tracked into #11105

Follow up from phase 1 (1.10)

Dropped

  • Check if NodeNetworkUnavailable must be added to MachineNodeHealthyCondition
    • Looks like NodeNetworkUnavailable is a left over of in tree gcp provider
  • Allow customisation of remote-conditions-grace-period at cluster level
  • InMemoryCluster and InMemoryMachine controllers
    • It is being merged in CAPD(ev)
@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. needs-priority Indicates an issue lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Nov 25, 2024
@fabriziopandini fabriziopandini added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Indicates an issue or PR is ready to be actively worked on. labels Nov 25, 2024
@k8s-ci-robot k8s-ci-robot removed needs-priority Indicates an issue lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Nov 25, 2024
@sbueringer sbueringer added this to the v1.10 milestone Dec 27, 2024
@sbueringer
Copy link
Member

Assigned to v1.10 for now to keep an eye on it. I think it's not clear yet in which release this will land.

@fabriziopandini
Copy link
Member Author

WRT to make new API fields kubectl explain compliant (rif #10897 (comment))

New fields introduced by the improve status proposal doesn't have fancy formatting anymore; never the less, it seems that this issue has been addressed in latest version of controller tools:

field with list using *

  template      <string>
    template defines the template to use for generating the name of the
    ControlPlane object.
    If not defined, it will fallback to `{{ .cluster.name }}-{{ .random }}`.
    If the templated string exceeds 63 characters, it will be trimmed to 58
    characters and will
    get concatenated with a random suffix of length 5.
    The templating mechanism provides the following arguments:
    * `.cluster.name`: The name of the cluster object.
    * `.random`: A random alphanumeric string, without vowels, of length 5.

field with list using -

  nodeStartupTimeout    <string>
    nodeStartupTimeout allows to set the maximum time for MachineHealthCheck
    to consider a Machine unhealthy if a corresponding Node isn't associated
    through a `Spec.ProviderID` field.

    The duration set in this field is compared to the greatest of:
    - Cluster's infrastructure ready condition timestamp (if and when available)
    - Control Plane's initialized condition timestamp (if and when available)
    - Machine's infrastructure ready condition timestamp (if and when available)
    - Machine's metadata creation timestamp

    Defaults to 10 minutes.
    If you wish to disable this feature, set the value explicitly to 0.

@fabriziopandini
Copy link
Member Author

All the work planned for 1.10 is completed (with the exception of MachinePools, but this is a wider discussion)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

No branches or pull requests

4 participants