Skip to content

🌱 Rename v1beta2 test types #11832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 13, 2025
Merged

🌱 Rename v1beta2 test types #11832

merged 1 commit into from
Feb 13, 2025

Conversation

fabriziopandini
Copy link
Member

What this PR does / why we need it:
small cleanup on the work on condition in the last cycle

@fabriziopandini fabriziopandini added the area/conditions Issues or PRs related to conditions label Feb 12, 2025
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 12, 2025
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 12, 2025
@fabriziopandini fabriziopandini mentioned this pull request Jan 13, 2025
Closed
10 tasks
@JoelSpeed
Copy link
Contributor

/lgtm

Seems like a reasonable name change to me

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 12, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 99c7f2d73a536bd89ca9e7dafd8f0cdd8ec7340e

sbueringer
sbueringer reviewed Feb 12, 2025
View reviewed changes
util/test/builder/v1beta2_transition.go Outdated
// Phase2ObjStatusDeprecated defines the status.Deprecated of a Phase2Obj.
type Phase2ObjStatusDeprecated struct {
// Phase2ObjDeprecatedStatus defines the status.Deprecated of a Phase2Obj.
type Phase2ObjDeprecatedStatus struct {

// +optional
V1Beta1 *Phase2ObjStatusDeprecatedV1Beta1 `json:"v1beta1,omitempty"`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also rename Phase2ObjStatusDeprecatedV1Beta1 to Phase2ObjDeprecatedV1Beta1Status

@sbueringer
Copy link
Member

Seems like some regen is missing

@fabriziopandini fabriziopandini force-pushed the rename-v1beta2-test-types branch from 346d74e to 29bf290 Compare February 13, 2025 13:19
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 13, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Feb 13, 2025 •
edited
Loading

@fabriziopandini: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-apidiff-main 29bf290 link false /test pull-cluster-api-apidiff-main

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

chrischdi
chrischdi reviewed Feb 13, 2025
View reviewed changes
Copy link
Member

@chrischdi chrischdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 13, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: a778ef4592ef38442c26496e43665b8eccd6bd1f

@sbueringer
Copy link
Member

Thx!

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 13, 2025
@k8s-ci-robot k8s-ci-robot merged commit 8cf4b86 into kubernetes-sigs:main Feb 13, 2025
18 of 19 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.10 milestone Feb 13, 2025
@fabriziopandini fabriziopandini deleted the rename-v1beta2-test-types branch February 19, 2025 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrischdi chrischdi chrischdi left review comments

@sbueringer sbueringer sbueringer left review comments

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

Assignees

@chrischdi chrischdi

@JoelSpeed JoelSpeed

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/conditions Issues or PRs related to conditions cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.10
Development

Successfully merging this pull request may close these issues.
5 participants
@fabriziopandini @JoelSpeed @k8s-ci-robot @sbueringer @chrischdi