Skip to content

Apply labels to Machines if they're part of a MD or MS #1695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
vincepri opened this issue Oct 30, 2019 · 4 comments · Fixed by #1711
Closed

Apply labels to Machines if they're part of a MD or MS #1695

vincepri opened this issue Oct 30, 2019 · 4 comments · Fixed by #1711
Assignees
@tahsinrahman
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.

Comments

@vincepri
Copy link
Member

User Story

As a user I would like to be able to quickly filter all Machines that are part of a MachineDeployment or MachineSet.

Detailed Description

We can adopt two new labels cluster.x-k8s.io/deployment-name and cluster.x-k8s.io/set-name (naming TBD, just an example) with the respective value being either the MD or MS names.

/kind feature
/help
/priority important-longterm
@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. labels Oct 30, 2019
@k8s-ci-robot
Copy link
Contributor

@vincepri:
This request has been marked as needing help from a contributor.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

User Story

As a user I would like to be able to quickly filter all Machines that are part of a MachineDeployment or MachineSet.

Detailed Description

We can adopt two new labels cluster.x-k8s.io/deployment-name and cluster.x-k8s.io/set-name (naming TBD, just an example) with the respective value being either the MD or MS names.

/kind feature
/help
/priority important-longterm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Oct 30, 2019
@detiber
Copy link
Member

detiber commented Oct 31, 2019

If we do this, in addition to the cluster.x-k8s.io/cluster-name label, we could potentially remove the label selectors from the specs and simplify the definitions of MS and MD resources.

@tahsinrahman
Copy link
Contributor

/assign

@tahsinrahman
Copy link
Contributor

/lifecycle active

@k8s-ci-robot k8s-ci-robot added the lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. label Oct 31, 2019
This was referenced Oct 31, 2019
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tahsinrahman tahsinrahman

Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Projects
None yet
Milestone
No milestone
4 participants
@detiber @vincepri @tahsinrahman @k8s-ci-robot